Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce required dependencies #116

Merged
merged 2 commits into from Jan 26, 2024
Merged

Conversation

HookedBehemoth
Copy link
Contributor

  • move env_logger to dev-dependencies (was only used in the examples)
  • move image functions behind existing feature flag

I bumped the version to 0.7.0 as this could be a breaking change for someone having appctx but not image enabled.

The motivation was to flatten the dependency tree, reduce build time and reduce target folder size.

- move env_logger to dev-dependencies
- move image functions behind feature flag
@bkirwi
Copy link
Collaborator

bkirwi commented Jan 8, 2024

Seems reasonable enough to me! I'm not aware of any real-world applications that use appctx, but it still seems wise to bump the version.

@fenollp / @LinusCDE - unless you object this seems mergeable?

@fenollp
Copy link
Collaborator

fenollp commented Jan 8, 2024

LGTM!

@LinusCDE LinusCDE merged commit f00fc82 into canselcik:master Jan 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants