-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clippy warnings + uprade some audited deps #115
Conversation
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making and mentioning it. Should have been merged a while ago ig. Just checked that current rust was still happy and fixed the new clippy lint error.
Lgtm!
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
If no issues are raised in the next few days, lets just merge this ig. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great!
(I should have more time to stay on top of changes like these soon, but also don't feel the need to block on me for them!)
Note: some audited deps are not simple to upgrade (and weren't). This needs further work:
Also: shouldn't we be setting dependency versions with broader constraints than an exact version number? e.g:
"1.0"
or"1"
? Lib consumers then should be able to upgrade their own deps before eventually making PRs against this repo