Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Meter component #14

Merged
merged 2 commits into from Oct 12, 2023

Conversation

petermakowski
Copy link
Collaborator

@petermakowski petermakowski commented Oct 11, 2023

Done

  • add Meter component

QA steps

  • Follow installation and local linking instructions in README.md
  • Replace import of Meter component in your local repository (other than maas-ui) with e.g. import { Meter, meterColor as color } from "@canonical/maas-react-components";
  • Verify the component works as before

Note

There's an issue with dependencies in maas-ui that results in an error about multiple react versions when following the QA steps above. This will be addressed separately.
facebook/react#13991 (comment)

@petermakowski petermakowski force-pushed the feat-add-meter branch 2 times, most recently from 09f0b85 to e5a39e9 Compare October 11, 2023 13:01
@petermakowski petermakowski marked this pull request as ready for review October 11, 2023 13:03
Copy link
Collaborator

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the most part, just one question below

package.json Show resolved Hide resolved
@petermakowski petermakowski merged commit 6593ab4 into canonical:main Oct 12, 2023
2 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants