Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv_writer: Don't skip later KAIO events when one is EAGAIN #652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cole-miller
Copy link
Contributor

@marco6 pointed out this return that should be a continue, which causes us to skip processing some KAIO write results if we get several of them in a batch and one of them has status code EAGAIN.

In practice, when running our test suite, it seems that io_getevents never returns more than one event in this context, which together with the dependence on getting EAGAIN explains why we never noticed this while developing dqlite or raft. But in production we could certainly encounter n_events > 1.

Signed-off-by: Cole Miller cole.miller@canonical.com

Signed-off-by: Cole Miller <cole.miller@canonical.com>
@cole-miller cole-miller requested a review from just-now May 3, 2024 14:56
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.43%. Comparing base (14bc162) to head (0710242).
Report is 164 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   81.22%   77.43%   -3.80%     
==========================================
  Files         192      196       +4     
  Lines       27059    27232     +173     
  Branches     4981     5440     +459     
==========================================
- Hits        21978    21086     -892     
- Misses       3487     4290     +803     
- Partials     1594     1856     +262     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants