github: Restore raft testing on other filesystems #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed, failures with xfs and btrfs are back: |
|
Does this mean that the CI is no longer going to be green? If that is the case, do we plan to fix this tests? |
|
I don't plan to merge this with the tests failing, we need to fix them one way or another. Currently trying to figure out whether there's a proper fix that doesn't cause the same issue as canonical/raft#485. |
Signed-off-by: Cole Miller <cole.miller@canonical.com>
cole-miller
force-pushed
the
restore-raft-fs-testing
branch
from
c08d8b0
to
8bac639
Compare
Signed-off-by: Cole Miller <cole.miller@canonical.com>
cole-miller
force-pushed
the
restore-raft-fs-testing
branch
from
8bac639
to
c104c0a
Compare
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
In practice it seems we want to use vsnprintf all over the place, so I don't know what the point of enabling this is. Signed-off-by: Cole Miller <cole.miller@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I neglected to set this up when doing the raft import, and was reminded because this additional testing should pick up the original issue that this patch---since reverted by #641---addressed.
Signed-off-by: Cole Miller cole.miller@canonical.com