Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured missing values for optional fields do not throw an error #379

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

jsoverson
Copy link
Contributor

Fixes #378

@fawadasaurus
Copy link
Contributor

@jsoverson I am still getting the same error. I am not passing groups_claim at all from the app.wick.

2023-07-18T21:03:20 ERROR trigger{kind=HTTP}: trigger failed to start: Configuration provided for component '/Users/fshaikh/Developer/candlecorp/wick-components/components/oauth/oauth-mssql.wick' does not match expected signature, missing field: groups_claim
component:
  kind: wick/component/composite@v1
  with:
    - name: auth_endpoint
      type: string
    - name: token_endpoint
      type: string
    - name: redirect_uri
      type: string
    - name: session_cookie_name
      type: string
    - name: client_id
      type: string
    - name: client_secret
      type: string
    - name: scope
      type: string
    - name: db_url
      type: string
    - name: email_claim
      type: string
    - name: groups_claim
      type: string?
      ```

@jsoverson
Copy link
Contributor Author

The liquid config is suboptimal. This PR would help if it lands: cobalt-org/liquid-rust#496

@jsoverson jsoverson merged commit ae1400c into main Jul 20, 2023
6 checks passed
@jsoverson jsoverson deleted the issue-378 branch July 20, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing values for optional configuration types throw an error
2 participants