Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump dependencies #263

Merged
merged 8 commits into from Nov 8, 2022
Merged

chore(deps): bump dependencies #263

merged 8 commits into from Nov 8, 2022

Conversation

danielkelemen
Copy link
Member

@danielkelemen danielkelemen changed the title chore(client): fix promises test issue chore(deps): bump dependencies Oct 14, 2022
@danielkelemen danielkelemen force-pushed the 2801-bump-dependencies branch 3 times, most recently from 49df31b to 01b730b Compare October 27, 2022 14:33
- update eslint to latest node@10 compatible version
- add explicit minimist version
- update prettier version & fix code format
@danielkelemen danielkelemen force-pushed the 2801-bump-dependencies branch 5 times, most recently from 43363fc to 53795ce Compare October 27, 2022 15:19
- update minimatch & path-parse transitive dependencies in lock file
- update eslint-plugin-jest
- regenerate snapshots
- remove minimist, v1.2.7 is installed by default
@danielkelemen danielkelemen added the dependencies Pull requests that update a dependency file label Oct 28, 2022
@danielkelemen
Copy link
Member Author

danielkelemen commented Oct 28, 2022

Version updates:

  • got: updated to 11.8.5, latest commonjs version
  • chalk: updated to 4.1.2, latest commonjs version
  • eslint: updated to 7.32.0, latest version that works with node@10
  • eslint-plugin-bpmn-io: updated to 0.14.1, latest eslint@7 compatible version
  • jest: updated to 27.5.1, latest version that works with node@10
  • other smaller packages are mostly updated to latest

Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update master to even higher versions? I don't think that sticking to node@10 is a hard requirement. We can document it in the migration guide and release version 3.0 to emphasize this change.

Patches of XTaC 2.3 and 2.2 should probably stick to node@10.

 chalk                    ^4.1.2  →   ^5.1.2     
 got                     ^11.8.5  →  ^12.5.2     
 eslint                  ^7.32.0  →  ^8.26.0     
 eslint-config-prettier    8.3.0  →    8.5.0     
 eslint-plugin-bpmn-io   ^0.14.1  →  ^0.16.0     
 jest                    ^27.5.1  →  ^29.2.2     

@danielkelemen
Copy link
Member Author

Can we update master to even higher versions?

Of course, we can. For the non cjs dependencies (got, chalk) we have to either introduce some transpiling or we can convert our client to esm, too.

@tasso94
Copy link
Member

tasso94 commented Nov 2, 2022

I'm okay with switching to ESM for master. I think that would pave the way to ensure maintainability in the future.

@danielkelemen danielkelemen changed the base branch from master to 2.3 November 2, 2022 15:15
@danielkelemen danielkelemen changed the base branch from 2.3 to master November 2, 2022 15:18
@danielkelemen
Copy link
Member Author

danielkelemen commented Nov 2, 2022

Created a separate issue for the final dependency & ESM updates: camunda/camunda-bpm-platform#2881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
2 participants