-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(engine): add operation log for sync delete process instance #4028
base: master
Are you sure you want to change the base?
Conversation
066b4c0
to
b4382df
Compare
b4382df
to
5939769
Compare
63d7a63
to
f437d57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me. I left 2 hints.
public Map<ProcessInstance, List<PropertyChange>> getPropChangesForOperation(List<ProcessInstance> results) { | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 Depending on how often this will be just return null
, this could be a default method in the interface.
runtimeService.deleteProcessInstance(instance1.getId(), null); | ||
|
||
// then | ||
UserOperationLogEntry logEntry = historyService.createUserOperationLogQuery().operationType(UserOperationLogEntry.OPERATION_TYPE_DELETE).singleResult(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 Widescreen monitor ftw. You could add some line breaks 😀 (Below too.)
UserOperationLogEntry logEntry = historyService.createUserOperationLogQuery().operationType(UserOperationLogEntry.OPERATION_TYPE_DELETE).singleResult(); | |
UserOperationLogEntry logEntry = historyService.createUserOperationLogQuery() | |
.operationType(UserOperationLogEntry.OPERATION_TYPE_DELETE) | |
.singleResult(); |
Related to #3932