Skip to content
This repository has been archived by the owner on Feb 1, 2018. It is now read-only.

Technical Writing week exercise - Readme for HaCS #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PandelisZ
Copy link
Contributor

@PandelisZ PandelisZ commented Apr 27, 2017

This commit is based on some of the things learnt in the campus-experts technical writing workshop. An image has been added to make the readme more visual, the description provides context for the repo and there has been a contributing guideline added. Build and test instructions we're simple and straightforward enough i believe so they remained the same

PS: totally just used cherry picking for the first time to make this PR cleaner. Super cool
The guide used

PR which adds this readme: HaCSBCU/hacsbcu.github.io#27

This commit is based on some of the things learnt in the campus-experts technical writing workshop. An image has been added to make the readme more visual, the description provides context for the repo and there has been a contributing guideline added. Build and test instructions we're simple and straightforward enough i believe so they remained the same
@PandelisZ PandelisZ force-pushed the hacs-readme-cherrypick/pandelisz branch from bae2227 to 9f0feff Compare April 27, 2017 21:04
Copy link
Contributor

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Very concise, but you mention everything someone finding this repo might need. Love how you explicitly tell people where to go to ask for help.

@PandelisZ
Copy link
Contributor Author

PandelisZ commented Apr 27, 2017

And for good measure, I've jazzed up the discuss repo readme too

https://github.com/campus-experts/discuss/pull/4

And this one. Not gonna lie, really proud of this one 😆

campus-experts/awesome-campus-expert#8

@joenash
Copy link

joenash commented May 12, 2017

👍 this is great, as were your other readmes. The only thing I'd say here, to bring in my feedback of your impact proposal as a whole, is that with your website there will be a lot of concepts totally alien to a lot of students. I don't know if the readme of the website itself is the place to address that, but it might be worth linking to an external document. Even reading what the website is, a horde of questions will arise:

  • What is Jekyll?
  • What is a static website?
  • Where do I run these commands?
  • What's gem? what's bundler?

Etc etc. Obviously you need to assume some knowledge somewhere, but it might be worth including a minimal "this is Ruby, this is a static site, here's where you can find out more" paragraph


Once you have ruby installed:

`$ gem install bundler`
Copy link
Contributor

@alyssais alyssais May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use code blocks to make commands on their own line look a bit nicer:

```sh
$ gem install bundler
```

(Which comes out like

$ gem install bundler

, instead of

$ gem install bundler

)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool


Once you have ruby installed:

`$ gem install bundler`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I've come across when introducing beginners to projects is that the $ at the start of a command can be more of a hindrance than a help — if people try to copy and paste the command into their terminal and don't know they have to remove the $ it won't work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback, Might as well remove them

@alyssais alyssais mentioned this pull request May 12, 2017
@@ -0,0 +1,38 @@
[![Build Status](https://travis-ci.org/HaCSBCU/hacsbcu.github.io.svg?branch=master)](https://travis-ci.org/HaCSBCU/hacsbcu.github.io)

![Website Screenshot](http://i.imgur.com/lJnqm1B.jpg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just being picky really but I noticed two things which might be ever so minor improvements.

  1. With Chrome if you hover in between the address bar and your addons, you get the option to drag the size of your addons menu around. When I'm doing screenshots I tend to crush this down to nothing, it's not nessesary but if you're looking for an extra clean finish it is a quick thing to do.
  2. The image you're linking to is on imgur, this is just a personal preference thing but I tend to keep even these images within the repo as they're part of your content.

Again, it's super picky and not anything which will greatly improve the readme (because it's already top notch) but maybe something to consider.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the image thing I've discovered the trick of posting in an issue to get the github cdn link, so its all within github and doesn't litter your repo.

I used that trick on the awesome repo and discuss

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great trick!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants