Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix list index out of range and float division by zero bug #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guet3401
Copy link

@guet3401 guet3401 commented Dec 16, 2020

Errors when using read pdf document.

@codecov-io
Copy link

Codecov Report

Merging #218 (6a6ad7d) into master (7709e58) will decrease coverage by 0.16%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   88.35%   88.19%   -0.17%     
==========================================
  Files          14       14              
  Lines        1571     1575       +4     
  Branches      358      359       +1     
==========================================
+ Hits         1388     1389       +1     
- Misses        128      131       +3     
  Partials       55       55              
Impacted Files Coverage Δ
camelot/utils.py 81.39% <28.57%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7709e58...6a6ad7d. Read the comment docs.

@vinayak-mehta
Copy link
Member

@guet3401 Thanks for the PR! Can you also add a test with a PDF where the code currently fails?

@olivierbouman
Copy link

olivierbouman commented Nov 11, 2021

Any updates on this PR? Merging this to master would solve some problems for me as well!:)

malinovy added a commit to malinovy/camelot that referenced this pull request Jun 8, 2023
@MartinThoma
Copy link
Contributor

Hey!

As camelot is dead, we try to build a maintained fork at pypdf_table_extraction.

Do you want to open the PR against that branch so that we can merge your improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants