Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install lodash dependency #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Install lodash dependency #30

wants to merge 1 commit into from

Conversation

lox
Copy link
Contributor

@lox lox commented Apr 10, 2023

Seems to require lodash.

@calvarium
Copy link
Owner

I don't see why this should be necessary. Can you justify this?

@lox
Copy link
Contributor Author

lox commented Sep 16, 2023

https://github.com/search?q=repo%3Acalvarium%2Fhomebridge-lifx-plugin%20lodash&type=code

@calvarium
Copy link
Owner

Since lodash is included in package-lock.json and will be installed with npm install, should we still add it to package.json? What is your opinion?

@lox
Copy link
Contributor Author

lox commented Sep 18, 2023

Yes, absolutely. If your code needs it, it needs to be in package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lox @calvarium