Removes trivial lodash #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I kept this as a draft because I don't know if I should include a CHANGELOG.md update in the PR |
danielmitre
force-pushed
the
removes-trivial-lodash
branch
from
4c41ed0
to
7606569
Compare
|
I saw this failed coming, but still can't replicate the failure in my local environment |
danielmitre
force-pushed
the
removes-trivial-lodash
branch
2 times, most recently
from
73c44fa
to
a169830
Compare
danielmitre
force-pushed
the
removes-trivial-lodash
branch
from
a169830
to
f1a7f40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes Lodash dependencies (all but
lodash.snakeCase) that are easily replaceable by an one-line function and/or some ES6 feature. This aim to reduce the SDK bundle size, which it does (from 130Kib to 95.8Kib minimized without compression).Most of changes were made writing a similar function just the complex enough to make the job done. Except for the
startUserPlaybackrefactoring, but I can do the same there.Type of change