Instrument existing klasses at initialization.

callstacking · May 15, 2023 · 1b1eb60 · 1b1eb60
1 parent 44fc729
commit 1b1eb60
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 10 deletions.
diff --git a/lib/callstacking/rails/engine.rb b/lib/callstacking/rails/engine.rb
@@ -38,12 +38,12 @@ class Engine < ::Rails::Engine
       config.after_initialize do
         Logger.log "Call Stacking loading (#{Callstacking::Rails::Env.environment})"
 
-        Logger.log("English defined? #{Object.const_defined?('English')}")
-
         spans[Thread.current.object_id]||=Spans.new
         instrumenter.add_span(spans[Thread.current.object_id])
 
         @@loader = Callstacking::Rails::Loader.new(instrumenter, excluded: settings.excluded + EXCLUDED_TEST_CLASSES)
+        @@loader.instrument_existing
+
         loader.on_load
         # loader.reset!
       end

diff --git a/lib/callstacking/rails/loader.rb b/lib/callstacking/rails/loader.rb
@@ -11,6 +11,12 @@ def initialize(instrumenter, excluded: [])
         @klasses = Set.new
       end
 
+      def instrument_existing
+        objs = []
+        ObjectSpace.each_object(Module){|ob| objs << [ob, ((Object.const_source_location(ob.to_s) rescue nil))].flatten}
+        objs.each{|o| filter_klass(o.first, o.last)}
+      end
+
       def on_load
         trace = TracePoint.new(:end) do |tp|
           klass = tp.self
@@ -19,14 +25,7 @@ def on_load
           Logger.log("Callstacking::Rails::Loader.on_load #{klass} #{path}")
           Logger.log("English defined? #{Object.const_defined?('English')}")
 
-          excluded_klass = excluded.any? { |ex| path =~ /#{ex}/ }
-
-          if path =~ /#{::Rails.root.to_s}/ &&
-            !klasses.include?(klass) &&
-            !excluded_klass
-              instrumenter.instrument_klass(klass)
-              klasses << klass
-          end
+          filter_klass(klass, path)
         end
 
         trace.enable
@@ -36,6 +35,18 @@ def reset!
         instrumenter.instrument_method(ActionView::PartialRenderer, :render, application_level: false)
         instrumenter.instrument_method(ActionView::TemplateRenderer, :render, application_level: false)
       end
+
+      private
+      def filter_klass(klass, path)
+        excluded_klass = excluded.any? { |ex| path =~ /#{ex}/ }
+
+        if path =~ /#{::Rails.root.to_s}/ &&
+          !klasses.include?(klass) &&
+          !excluded_klass
+          instrumenter.instrument_klass(klass)
+          klasses << klass
+        end
+      end
     end
   end
 end