New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Possible Improvements #304
base: main
Are you sure you want to change the base?
Various Possible Improvements #304
Conversation
Lots of great things in here, thanks especially for the security hardening. I'll need to verify the changes for the database at build-time. That was required by the build process for doing inserts based on env config values for the plugins, and not required only for the migrations. Did you by chance check on that as well? |
c3a5a6f
to
2e0b4f4
Compare
Thanks for taking a look. I think I addressed the two issues, let me know how it looks. |
27fe632
to
8ad507e
Compare
8ad507e
to
4f6cddd
Compare
Here's what I think the main open questions are, in summary:
|
I'm still working to get some confirmation on the changes that have allowed the removal of the build-time variable insertion. |
That makes sense. This set up assumes that the user wants to take the Dockerfile and get the software running as quickly as possible, but there are other considerations around publishing the official image and supporting workflows with custom updates to the codebase. Are there any of the updates from this PR that seem ready to go (or close)? I can pull them out into a separate PR if you'd like. To me it seems straightforward for a user to change the main Note that by default, using ADD with a git link does not pull from the repo every time, it is cached and only pulled when the tag (or commit SHA) has changed. Of course if that layer is deleted, for example by running |
I've continued to work on this. I've made some updates and now I have it running with v4.0.7. I haven't pushed it here. Is there any interest in any of the features in the PR? Zoom works fine; that's the only integration I am using though. Happy to run other tests if there is interest. Also happy to separate into smaller PRs, if the work is valuable to anyone else. |
I've been setting up cal.com using Docker, and found some possible improvements that may be of use to the community:
Of any use?