Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Booking Cancelled Webhook - Organiser webhook payload is missing id. #14697 #14745

Merged
merged 11 commits into from May 6, 2024

Conversation

vikaspatil0021
Copy link
Contributor

@vikaspatil0021 vikaspatil0021 commented Apr 25, 2024

Fixes: #14697

What does this PR do?

fixes the missing id and username information that is available on the Created and Rescheduled webhook payloads.

Copy link

vercel bot commented Apr 25, 2024

@vikaspatil0021 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team April 25, 2024 08:44
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 25, 2024
Copy link
Contributor

github-actions bot commented Apr 25, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Apr 25, 2024
Copy link

graphite-app bot commented Apr 25, 2024

Graphite Automations

"Add community label" took an action on this PR • (04/25/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (04/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (04/26/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 25, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions github-actions bot added High priority Created by Linear-GitHub Sync webhooks area: webhooks, callback, webhook payload labels Apr 25, 2024
@vikaspatil0021
Copy link
Contributor Author

@alishaz-polymath Please review.

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @vikaspatil0021 could you also add this in tests?

@vikaspatil0021
Copy link
Contributor Author

Hey @Udit-takkar,

export function getOrganizer({


here organizer structure is different and id already exists. should i add username to them?

@Udit-takkar
Copy link
Contributor

here organizer structure is different and id already exists. should i add username to them?

No not here. check expectBookingCreatedWebhookToHaveBeenFired function in apps/web/test/utils/bookingScenario/expects.ts. create a similar function to check booking cancelled webhook

@vikaspatil0021
Copy link
Contributor Author

@Udit-takkar Please check

@Udit-takkar
Copy link
Contributor

Udit-takkar commented Apr 26, 2024

@vikaspatil0021 use prettier and then push the code. getting lint error in CI

@vikaspatil0021
Copy link
Contributor Author

@Udit-takkar Please check

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikaspatil0021 you don't have to push yarn.lock file in this PR. Please use

git checkout origin/main -- yarn.lock
and then pushing yarn.lock file to undo the changes in yarn.lock file.

  1. You haven't added the test. you are not calling the function that you created anywhere.

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

TODO: #14886

@Udit-takkar Udit-takkar enabled auto-merge (squash) May 6, 2024 07:59
@Udit-takkar Udit-takkar merged commit 8deedfd into calcom:main May 6, 2024
32 of 40 checks passed
@vikaspatil0021 vikaspatil0021 deleted the fix/missing-id branch May 6, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync webhooks area: webhooks, callback, webhook payload
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Booking Cancelled Webhook - Organiser webhook payload is missing id.
2 participants