New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Booking Cancelled Webhook - Organiser webhook payload is missing id. #14697 #14745
Conversation
@vikaspatil0021 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add community label" took an action on this PR • (04/25/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (04/25/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (04/26/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
@alishaz-polymath Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @vikaspatil0021 could you also add this in tests?
Hey @Udit-takkar,
here organizer structure is different and id already exists. should i add username to them?
|
No not here. check |
@Udit-takkar Please check |
@vikaspatil0021 use prettier and then push the code. getting lint error in CI |
519ceab
to
f406bd2
Compare
@Udit-takkar Please check |
f406bd2
to
d533e7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vikaspatil0021 you don't have to push yarn.lock file in this PR. Please use
git checkout origin/main -- yarn.lock
and then pushing yarn.lock file to undo the changes in yarn.lock file.
- You haven't added the test. you are not calling the function that you created anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
TODO: #14886
Fixes: #14697
What does this PR do?
fixes the missing
id
andusername
information that is available on the Created and Rescheduled webhook payloads.