Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reschedule with google meet #14730

Merged
merged 16 commits into from May 7, 2024
Merged

fix: reschedule with google meet #14730

merged 16 commits into from May 7, 2024
+298 −17

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Apr 24, 2024 •
edited

What does this PR do?

Fixes #14086
Fixes CAL-3462

Before:-
image

After:-
Screenshot 2024-04-24 at 6 25 32 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@linear Linear
Copy link

linear bot commented Apr 24, 2024

CAL-3462 Google Meet link missing after rescheduling team meeting

@Udit-takkar Udit-takkar added this to the v4.1 milestone Apr 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email High priority Created by Linear-GitHub Sync 🐛 bug Something isn't working 📉 regressing This used to work. Now it doesn't anymore. labels Apr 24, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Apr 24, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 0:10am
platform-starter-kit ❌ Failed (Inspect) May 7, 2024 0:10am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:10am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:10am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel DeploySentinel
Copy link

deploysentinel bot commented Apr 24, 2024 •
edited

Current Playwright Test Results Summary

✅ 37 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/07/2024 12:35:34pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 25b2916

Started: 05/07/2024 12:33:34pm UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

 2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 2 • Retry 1 • Initial Attempt
20% (63) 63 / 315 runs
failed over last 7 days
31.75% (100) 100 / 315 runs
flaked over last 7 days
Update Profile Can resend verification link if the secondary email is unverified
Retry 1 • Initial Attempt
6.67% (21) 21 / 315 runs
failed over last 7 days
19.05% (60) 60 / 315 runs
flaked over last 7 days
📄   packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1 • Initial Attempt
17.55% (56) 56 / 319 runs
failed over last 7 days
39.18% (125) 125 / 319 runs
flaked over last 7 days

View Detailed Build Results

@emrysal emrysal marked this pull request as ready for review April 24, 2024 13:31
@graphite-app graphite-app bot requested a review from a team April 24, 2024 13:31
@emrysal emrysal self-requested a review April 24, 2024 13:31
emrysal
emrysal previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Udit-takkar! Looks like a good fix to me for updatedEvents - nice one.

@graphite-app Graphite App
Copy link

graphite-app bot commented Apr 24, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@Udit-takkar
Copy link
Contributor Author

Screenshot 2024-05-06 at 4 57 16 PM

@hariombalhara Added appStatus assertion and verified that it fails on main branch

Udit-takkar
Udit-takkar commented May 6, 2024
View reviewed changes
packages/features/bookings/lib/handleNewBooking/test/reschedule.test.ts Outdated
Comment on lines 1142 to 1143
test(
`[GOOGLE MEET AS LOCATIOn]should rechedule a booking, that requires confirmation, without confirmation - When booker is the organizer of the existing booking as well as the event-type
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test on individual event type

@Udit-takkar Udit-takkar merged commit 3f4d996 into main May 7, 2024
41 checks passed
@Udit-takkar Udit-takkar deleted the fix/google-meet-reschedule branch May 7, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariombalhara hariombalhara hariombalhara approved these changes

@emrysal emrysal Awaiting requested review from emrysal

Assignees
No one assigned
Labels
automated-tests area: unit tests, e2e tests, playwright bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working consumer core area: core, team members only emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email High priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore.
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.

[CAL-3462] Google Meet link missing after rescheduling team meeting
5 participants
@Udit-takkar @emrysal @hariombalhara @keithwillcode @CarinaWolli