Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Drag & drop for re-ordering event types (without any external library) #14719

Closed
wants to merge 4 commits into from

Conversation

anikdhabal
Copy link
Contributor

What does this PR do?

Fixes #14701

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 23, 2024
@graphite-app graphite-app bot requested a review from a team April 23, 2024 15:11
Copy link

vercel bot commented Apr 23, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added event-types area: event types, event-types Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Apr 23, 2024
@dosubot dosubot bot added core area: core, team members only ✨ feature New feature or request labels Apr 23, 2024
Copy link
Contributor

github-actions bot commented Apr 23, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

graphite-app bot commented Apr 23, 2024

Graphite Automations

"Add community label" took an action on this PR • (04/23/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (04/23/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 23, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@zomars
Copy link
Member

zomars commented Apr 23, 2024

This is quite clever. Good job. Could you please attach a loom or video demoing it? 🙏

@anikdhabal
Copy link
Contributor Author

This is quite clever. Good job. Could you please attach a loom or video demoing it? 🙏

Sure @zomars 🙏

260444574-7cc0ca2c-ab32-40d8-b57d-3e332123c9fd.1.mp4

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and worked fine but it swaps both the event types instead of moving only one. is this fine @ciaranha?

Screen.Recording.2024-04-24.at.2.08.42.PM.mov

@sean-brydon
Copy link
Member

Tested this and worked fine but it swaps both the event types instead of moving only one. is this fine @ciaranha?

Screen.Recording.2024-04-24.at.2.08.42.PM.mov

Yeah I was testing this and notice this too - i was checking a few drag and drop instances across a few different apps and they all seem to have a mixture of inserting it where you dropped it and swapping. I think its just a matter of preference.

I would lean to inserting as that is kinda what happens when you use the arrows

@ciaranha
Copy link
Member

ciaranha commented Apr 24, 2024

Tested this and worked fine but it swaps both the event types instead of moving only one. is this fine @ciaranha?

No, this is weird. I'm sure the fact that it looks like you're picking up a URL could be worked on, but the swap thing is not what we want.

@anikdhabal
Copy link
Contributor Author

anikdhabal commented Apr 24, 2024

@Udit-takkar @sean-brydon @ciaranha thanks for your review. I understand what's needed, and I'm on it. I will fix it shortly.

@ciaranha
Copy link
Member

I'd like for us to have a specific draggable area rather than the whole thing draggable as re-ordering is not a super high need, but in terms of the interaction, this is more what I would hope for:

CleanShot.2024-04-24.at.14.08.24.mp4

Requirements

  • It's clear what I'm dragging
  • It's clear where I'm going to drop it and how that will impact the items around it
  • It should feel smooth and predictable

@keithwillcode keithwillcode added this to the v4.1 milestone May 8, 2024
@keithwillcode
Copy link
Contributor

Closing for now based on @ciaranha comments. Feel free to reopen if changes are made.

@dosubot dosubot bot removed this from the v4.1 milestone May 9, 2024
@anikdhabal
Copy link
Contributor Author

Closing for now based on @ciaranha comments. Feel free to reopen if changes are made.

Yeah, I will fix it shortly and reopen it.

@dosubot dosubot bot modified the milestone: v4.2 May 9, 2024
@dosubot dosubot bot modified the milestone: v4.1 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync core area: core, team members only event-types area: event types, event-types ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3514] Drag & drop for re-ordering event types
7 participants