New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Drag & drop for re-ordering event types (without any external library) #14719
Conversation
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add community label" took an action on this PR • (04/23/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (04/23/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This is quite clever. Good job. Could you please attach a loom or video demoing it? 🙏 |
Sure @zomars 🙏 260444574-7cc0ca2c-ab32-40d8-b57d-3e332123c9fd.1.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this and worked fine but it swaps both the event types instead of moving only one. is this fine @ciaranha?
Screen.Recording.2024-04-24.at.2.08.42.PM.mov
Yeah I was testing this and notice this too - i was checking a few drag and drop instances across a few different apps and they all seem to have a mixture of inserting it where you dropped it and swapping. I think its just a matter of preference. I would lean to inserting as that is kinda what happens when you use the arrows |
No, this is weird. I'm sure the fact that it looks like you're picking up a URL could be worked on, but the swap thing is not what we want. |
@Udit-takkar @sean-brydon @ciaranha thanks for your review. I understand what's needed, and I'm on it. I will fix it shortly. |
I'd like for us to have a specific draggable area rather than the whole thing draggable as re-ordering is not a super high need, but in terms of the interaction, this is more what I would hope for: CleanShot.2024-04-24.at.14.08.24.mp4Requirements
|
Closing for now based on @ciaranha comments. Feel free to reopen if changes are made. |
Yeah, I will fix it shortly and reopen it. |
What does this PR do?
Fixes #14701