Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added notifications feature #14716

Closed
wants to merge 1 commit into from
Closed

Conversation

thepradipvc
Copy link
Contributor

What does this PR do?

This PR adds an Allow Notifications button to the bookings page and sends notifications for all the unconfirmed events. It also notifies the user again after an hour if the user has not taken action.

Fixes #14504
/claim #14504

https://www.loom.com/share/5db0fd26018840a1a48d70293b00829a?sid=1fed16f4-a4d3-4346-b066-8cda16697f7b

Type of change

  • New feature (non-breaking change which adds functionality)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Apr 23, 2024

@thepradipvc is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

algora-pbc bot commented Apr 23, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay.

@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking Low priority Created by Linear-GitHub Sync labels Apr 23, 2024
Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added ui area: UI, frontend, button, form, input ✨ feature New feature or request 💎 Bounty A bounty on Algora.io labels Apr 23, 2024
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Sixty-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 277.12 KB 505.53 KB 144.44% (🟡 +0.14%)
/apps/[slug] 294.83 KB 523.25 KB 149.50% (🟡 +0.14%)
/apps/[slug]/[...pages] 586 KB 814.41 KB 232.69% (🟡 +0.14%)
/apps/categories 255.09 KB 483.5 KB 138.14% (🟡 +0.15%)
/apps/categories/[category] 259.41 KB 487.82 KB 139.38% (🟡 +0.14%)
/apps/installed/[category] 278.53 KB 506.94 KB 144.84% (🟡 +0.14%)
/availability 463.2 KB 691.61 KB 197.60% (🟡 +0.15%)
/availability/[schedule] 409.56 KB 637.97 KB 182.28% (🟡 +0.14%)
/bookings/[status] 322.84 KB 551.25 KB 157.50% (🟡 +0.15%)
/enterprise 255.15 KB 483.56 KB 138.16% (🟡 +0.14%)
/event-types 555.18 KB 783.59 KB 223.88% (🟡 +0.15%)
/event-types/[type] 434.25 KB 662.66 KB 189.33% (🟡 +0.15%)
/insights 473.56 KB 701.97 KB 200.56% (🟡 +0.15%)
/more 254.65 KB 483.06 KB 138.02% (🟡 +0.14%)
/settings/admin 260.93 KB 489.34 KB 139.81% (🟡 +0.15%)
/settings/admin/apps 273.75 KB 502.16 KB 143.47% (🟡 +0.15%)
/settings/admin/apps/[category] 273.71 KB 502.12 KB 143.46% (🟡 +0.15%)
/settings/admin/flags 264.74 KB 493.15 KB 140.90% (🟡 +0.14%)
/settings/admin/impersonation 261.23 KB 489.64 KB 139.90% (🟡 +0.14%)
/settings/admin/oAuth 272.37 KB 500.78 KB 143.08% (🟡 +0.14%)
/settings/admin/orgMigrations/_OrgMigrationLayout 249.52 KB 477.93 KB 136.55% (🟡 +0.15%)
/settings/admin/orgMigrations/moveTeamToOrg 298.45 KB 526.86 KB 150.53% (🟡 +0.15%)
/settings/admin/orgMigrations/moveUserToOrg 317.71 KB 546.12 KB 156.03% (🟡 +0.15%)
/settings/admin/orgMigrations/removeTeamFromOrg 298.23 KB 526.64 KB 150.47% (🟡 +0.14%)
/settings/admin/orgMigrations/removeUserFromOrg 298.24 KB 526.66 KB 150.47% (🟡 +0.15%)
/settings/admin/organizations 262.81 KB 491.22 KB 140.35% (🟡 +0.14%)
/settings/admin/organizations/[id]/edit 261.48 KB 489.89 KB 139.97% (🟡 +0.14%)
/settings/admin/users 263.58 KB 491.99 KB 140.57% (🟡 +0.14%)
/settings/admin/users/[id]/edit 391.61 KB 620.02 KB 177.15% (🟡 +0.14%)
/settings/admin/users/add 391.35 KB 619.76 KB 177.07% (🟡 +0.15%)
/settings/billing 261.14 KB 489.55 KB 139.87% (🟡 +0.14%)
/settings/developer/api-keys 265.51 KB 493.92 KB 141.12% (🟡 +0.15%)
/settings/developer/webhooks 265.64 KB 494.05 KB 141.16% (🟡 +0.14%)
/settings/developer/webhooks/[id] 266.59 KB 495 KB 141.43% (🟡 +0.14%)
/settings/developer/webhooks/new 266.62 KB 495.03 KB 141.44% (🟡 +0.14%)
/settings/my-account/appearance 313.65 KB 542.06 KB 154.88% (🟡 +0.14%)
/settings/my-account/calendars 272.11 KB 500.52 KB 143.01% (🟡 +0.14%)
/settings/my-account/conferencing 273 KB 501.41 KB 143.26% (🟡 +0.14%)
/settings/my-account/general 378.8 KB 607.21 KB 173.49% (🟡 +0.14%)
/settings/my-account/out-of-office 266.12 KB 494.53 KB 141.29% (🟡 +0.15%)
/settings/my-account/profile 404.38 KB 632.79 KB 180.80% (🟡 +0.14%)
/settings/organizations/appearance 284.81 KB 513.22 KB 146.64% (🟡 +0.14%)
/settings/organizations/billing 261.17 KB 489.58 KB 139.88% (🟡 +0.15%)
/settings/organizations/dsync 330.56 KB 558.97 KB 159.71% (🟡 +0.14%)
/settings/organizations/general 348.44 KB 576.85 KB 164.82% (🟡 +0.14%)
/settings/organizations/members 429.24 KB 657.66 KB 187.90% (🟡 +0.14%)
/settings/organizations/platform/oauth-clients 263.46 KB 491.87 KB 140.53% (🟡 +0.15%)
/settings/organizations/platform/oauth-clients/create 263.56 KB 491.97 KB 140.56% (🟡 +0.15%)
/settings/organizations/privacy 266.32 KB 494.73 KB 141.35% (🟡 +0.14%)
/settings/organizations/profile 396.92 KB 625.33 KB 178.67% (🟡 +0.14%)
/settings/organizations/sso 271.6 KB 500.01 KB 142.86% (🟡 +0.14%)
/settings/organizations/teams/other 262 KB 490.41 KB 140.12% (🟡 +0.14%)
/settings/organizations/teams/other/[id]/appearance 273.65 KB 502.06 KB 143.45% (🟡 +0.14%)
/settings/organizations/teams/other/[id]/members 268.47 KB 496.88 KB 141.97% (🟡 +0.14%)
/settings/organizations/teams/other/[id]/profile 467.73 KB 696.15 KB 198.90% (🟡 +0.14%)
/settings/security/impersonation 266.32 KB 494.74 KB 141.35% (🟡 +0.15%)
/settings/security/password 303.26 KB 531.67 KB 151.91% (🟡 +0.14%)
/settings/security/sso 270.92 KB 499.33 KB 142.67% (🟡 +0.14%)
/settings/security/two-factor-auth 269.79 KB 498.2 KB 142.34% (🟡 +0.15%)
/settings/teams 260.67 KB 489.08 KB 139.74% (🟡 +0.14%)
/settings/teams/[id]/appearance 273.63 KB 502.04 KB 143.44% (🟡 +0.15%)
/settings/teams/[id]/billing 261.17 KB 489.59 KB 139.88% (🟡 +0.15%)
/settings/teams/[id]/members 380.63 KB 609.04 KB 174.01% (🟡 +0.14%)
/settings/teams/[id]/profile 468.57 KB 696.98 KB 199.14% (🟡 +0.14%)
/teams 254.88 KB 483.29 KB 138.08% (🟡 +0.15%)
/upgrade 255 KB 483.41 KB 138.12% (🟡 +0.14%)
/workflows 286.22 KB 514.63 KB 147.04% (🟡 +0.14%)
/workflows/[workflow] 408.58 KB 637 KB 182.00% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🙋 Bounty claim 💎 Bounty A bounty on Algora.io ✨ feature New feature or request Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3390] Browser Notifications
1 participant