Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove deprecated logo/avatar/away fields #14705

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Apr 22, 2024

What does this PR do?

  • Drops away, avatar fields from users
  • Drops logo field from Team

@graphite-app graphite-app bot requested a review from a team April 22, 2024 17:01
Copy link
Contributor

github-actions bot commented Apr 22, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added the ❗️ migrations contains migration files label Apr 22, 2024
@dosubot dosubot bot added core area: core, team members only foundation labels Apr 22, 2024
Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 7:04pm
platform-starter-kit ❌ Failed (Inspect) May 6, 2024 7:04pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 7:04pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 7:04pm

Copy link

graphite-app bot commented Apr 22, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/22/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 22, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 22, 2024

Current Playwright Test Results Summary

✅ 311 Passing - ❌ 2 Failing - ⚠️ 11 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/06/2024 10:08:41pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: acd81e7

Started: 05/06/2024 10:04:27pm UTC

❌ Failures

📄   apps/web/playwright/workflow.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Workflow Tab - Event Type Check the functionalities of the Workflow Tab Team Workflows Admin user
Retry 1Initial Attempt
Error: expect(received).toHaveCount(expected) // deep equality...
expect(received).toHaveCount(expected) // deep equality

Expected: 4
Received: 0
Call log:
  - expect.toHaveCount with timeout 30000ms
  - waiting for locator('[data-testid="workflow-list"] > li')
  -   locator resolved to 0 elements
  -   unexpected value "0"
  - waiting for locator('[data-testid="workflow-list"] > li')
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"

2.91% (9) 9 / 309 runs
failed over last 7 days
0% (0) 0 / 309 runs
flaked over last 7 days

📄   packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 2Retry 1Initial Attempt
Error: Expected to provide an iframe, got null
Expected to provide an iframe, got null
16.32% (55) 55 / 337 runs
failed over last 7 days
41.25% (139) 139 / 337 runs
flaked over last 7 days

⚠️ Flakes

📄   apps/web/playwright/integrations-stripe.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
0.63% (2) 2 / 320 runs
failed over last 7 days
14.69% (47) 47 / 320 runs
flaked over last 7 days
Stripe integration Paid booking should be able to be rescheduled
Retry 1Initial Attempt
2.19% (7) 7 / 319 runs
failed over last 7 days
6.90% (22) 22 / 319 runs
flaked over last 7 days
Stripe integration Paid booking should be able to be cancelled
Retry 1Initial Attempt
0.63% (2) 2 / 318 runs
failed over last 7 days
6.60% (21) 21 / 318 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user can add multiple organizer address
Retry 1Initial Attempt
0.29% (1) 1 / 344 run
failed over last 7 days
19.19% (66) 66 / 344 runs
flaked over last 7 days
Event Types tests -- legacy user enabling recurring event comes with default options
Retry 1Initial Attempt
0.29% (1) 1 / 342 run
failed over last 7 days
3.80% (13) 13 / 342 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load if correct embedLibUrl is provided
Retry 1Initial Attempt
0% (0) 0 / 116 runs
failed over last 7 days
38.79% (45) 45 / 116 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
15.66% (52) 52 / 332 runs
failed over last 7 days
31.93% (106) 106 / 332 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 1Initial Attempt
7.18% (25) 25 / 348 runs
failed over last 7 days
26.15% (91) 91 / 348 runs
flaked over last 7 days
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 1Initial Attempt
13.79% (48) 48 / 348 runs
failed over last 7 days
24.71% (86) 86 / 348 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- legacy login flow user & logout using dashboard
Retry 1Initial Attempt
0% (0) 0 / 336 runs
failed over last 7 days
8.93% (30) 30 / 336 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
BOOKING_REJECTED can book an event that requires confirmation and then that booking can be rejected by organizer
Retry 1Initial Attempt
0% (0) 0 / 312 runs
failed over last 7 days
4.49% (14) 14 / 312 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@CarinaWolli
Copy link
Member

Why do all e2e tests fail here? I already tried re-running them 🤔

Copy link

vercel bot commented May 2, 2024

Deployment failed with the following error:

Too many requests - try again in 1 minute (more than 60, code: "api-deployments-flood").

@keithwillcode
Copy link
Contributor

@emrysal Looks like e2e 6/7 are failing consistently. Might need to look into it a bit more

Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for this reason: #14705 (comment)

@keithwillcode keithwillcode added this to the v4.1 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only foundation ❗️ migrations contains migration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants