Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: "Add an Override" calendar starts with the day specified in general settings #14663

Merged
merged 9 commits into from May 6, 2024

Conversation

shaik-zeeshan
Copy link
Contributor

@shaik-zeeshan shaik-zeeshan commented Apr 19, 2024

What does this PR do?

Fixes #14334

Before, Add an Override calendar in Availability page starts with Sunday
Screen Shot 2024-04-19 at 10 26 59 AM

After, calendar starts with day user has specified in general settings
Screen Shot 2024-04-19 at 10 27 18 AM

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Apr 19, 2024

@shaik-zeeshan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 19, 2024
@graphite-app graphite-app bot requested a review from a team April 19, 2024 05:07
@CLAassistant
Copy link

CLAassistant commented Apr 19, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added booking-page area: booking page, public booking page, booker Low priority Created by Linear-GitHub Sync labels Apr 19, 2024
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label Apr 19, 2024
@github-actions github-actions bot added the ✅ good first issue Good for newcomers label Apr 19, 2024
@dosubot dosubot bot added the ui area: UI, frontend, button, form, input label Apr 19, 2024
@github-actions github-actions bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Apr 19, 2024
@dosubot dosubot bot added the ✨ feature New feature or request label Apr 19, 2024
Copy link
Contributor

github-actions bot commented Apr 19, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

graphite-app bot commented Apr 19, 2024

Graphite Automations

"Add community label" took an action on this PR • (04/19/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (04/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 19, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far @shaik-zeeshan!

One thing I would like to see before merging is when editing an override, we should also use the user's weekStart

@shaik-zeeshan
Copy link
Contributor Author

i have update the edit calendar to use user's weekday @joeauyeung
Screenshot 2024-04-26 at 9 22 34 PM

Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback and your contribution @shaik-zeeshan

@keithwillcode keithwillcode merged commit b2baaea into calcom:main May 6, 2024
33 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
booking-page area: booking page, public booking page, booker bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync ✨ feature New feature or request ✅ good first issue Good for newcomers 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"First Day of Week" Setting for "Add an Override" Calendar: Ability to Select Monday as First Day of Week
4 participants