feat: handle v2 access tokens and api keys using BearerGuard #14643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 307 Passing - ❌ 1 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/18/2024 01:12:34pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 035471a Started: 04/18/2024 01:08:16pm UTC ❌ Failures📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 FailureTest Case Results
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0% (0)0 / 291 runsfailed over last 7 days |
22.34% (65)65 / 291 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Login and logout tests -- future Login flow validations -- future Should warn when user does not exist
Retry 1 • Initial Attempt |
0.34% (1)1 / 297 runfailed over last 7 days |
6.73% (20)20 / 297 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 2 • Retry 1 • Initial Attempt |
6.44% (19)19 / 295 runsfailed over last 7 days |
25.08% (74)74 / 295 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 18 runsfailed over last 7 days |
50% (9)9 / 18 runsflaked over last 7 days |
|
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt |
0% (0)0 / 18 runsfailed over last 7 days |
55.56% (10)10 / 18 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt |
0% (0)0 / 18 runsfailed over last 7 days |
44.44% (8)8 / 18 runsflaked over last 7 days |
|
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt |
0% (0)0 / 18 runsfailed over last 7 days |
44.44% (8)8 / 18 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
3.90% (12)12 / 308 runsfailed over last 7 days |
39.61% (122)122 / 308 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 1 • Initial Attempt |
5.75% (18)18 / 313 runsfailed over last 7 days |
36.74% (115)115 / 313 runsflaked over last 7 days |
| let bearerTokenUser: UserWithProfile; | ||
|
|
||
| if (!bearerToken) { | ||
| throw new UnauthorizedException(INVALID_ACCESS_TOKEN); |
There was a problem hiding this comment.
maybe rename this error to invalid authentication credentials
|
This PR is being marked as stale due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Combine AccessTokenStrategy and ApiKeyStrategy into BearerStrategy that can be applied to be used by v1 and v2 calls.