Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: events apps new install flow #14616

Open
wants to merge 141 commits into
base: main
Choose a base branch
from

Conversation

SomayChauhan
Copy link
Member

@SomayChauhan SomayChauhan commented Apr 16, 2024

What does this PR do?

Fixes #13414
Fixes CAL-3029

LOOM 1
LOOM2

this PR is a collective PR for different PRs(#11975 and #14077) that were tested individually and merged together into this pr

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is a UI/UX design document, please, share it here.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Tests (Unit/Integration/E2E or any other test)

How should this be tested?

checkout the looms, they explain the "How" to in great detail.

-testcasses:

  • for all the apps that dont extend event-types there is no change.
  • for all the apps that extend event-types i.e. all the analytics apps + payment apps + qr_code + Giphy + basecamp3 we follow the new flow
  • for the apps that go to the new flow we can click on the skip button and enable apps individually in event-type/apps

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

ThyMinimalDev and others added 30 commits October 20, 2023 11:25
… install flow if it is an oAuth app or an app that extends the EventType feature in it's config
@SomayChauhan
Copy link
Member Author

not entirely sure if the failing tests are related

@emrysal emrysal requested a review from zomars May 2, 2024 12:30
@keithwillcode keithwillcode added this to the v4.1 milestone May 8, 2024
@zomars
Copy link
Member

zomars commented May 9, 2024

Found this while testing. owner1 is both owner of a team and an organization. It has the following event types:

image

I'm trying to install Stripe for the owner1 profile (not the team):

image

But when coming back from the Stripe callback I get presented with both the org and team event types to setup. Even tho I only installed it for the user.

image

Is this the intended behavior? Shouldn't we only show the event types of the entity is being currently installed on?

@dosubot dosubot bot modified the milestones: v4.1, v4.2 May 9, 2024
@SomayChauhan
Copy link
Member Author

Is this the intended behavior? Shouldn't we only show the event types of the entity is being currently installed on?

this should definately not be the case, looking into this

@SomayChauhan
Copy link
Member Author

@zomars pushed a fix!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar automated-tests area: unit tests, e2e tests, playwright community Created by Linear-GitHub Sync core area: core, team members only ✨ feature New feature or request High priority Created by Linear-GitHub Sync high-risk Requires approval by Foundation team 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand platform Anything related to our platform plan 🚧 wip / in the making This is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3029] App store install flow
8 participants