New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: events apps new install flow #14616
Open
SomayChauhan
wants to merge
141
commits into
calcom:main
Choose a base branch
from
SomayChauhan:new-app-install-flow-2
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,561
−690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w' into new-app-install-flow
… install flow if it is an oAuth app or an app that extends the EventType feature in it's config
not entirely sure if the failing tests are related |
this should definately not be the case, looking into this |
@zomars pushed a fix!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
area: API, enterprise API, access token, OAuth
app-store
area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar
automated-tests
area: unit tests, e2e tests, playwright
community
Created by Linear-GitHub Sync
core
area: core, team members only
✨ feature
New feature or request
High priority
Created by Linear-GitHub Sync
high-risk
Requires approval by Foundation team
🚨 needs approval
This feature request has not been reviewed yet by the Product Team and needs approval beforehand
platform
Anything related to our platform plan
🚧 wip / in the making
This is currently being worked on
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13414
Fixes CAL-3029
LOOM 1
LOOM2
this PR is a collective PR for different PRs(#11975 and #14077) that were tested individually and merged together into this pr
Requirement/Documentation
Type of change
How should this be tested?
checkout the looms, they explain the "How" to in great detail.
-testcasses:
Mandatory Tasks