Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cal-3452 parameter for impersonation #14605

Merged
merged 18 commits into from May 7, 2024

Conversation

sean-brydon
Copy link
Member

What does this PR do?

Fixes CAL-3452
Fixes: #14595

CleanShot.2024-04-16.at.11.29.15.mp4

Copy link

linear bot commented Apr 16, 2024

@graphite-app graphite-app bot requested a review from a team April 16, 2024 10:30
@github-actions github-actions bot added the api area: API, enterprise API, access token, OAuth label Apr 16, 2024
@dosubot dosubot bot added the core area: core, team members only label Apr 16, 2024
@github-actions github-actions bot added the ✨ feature New feature or request label Apr 16, 2024
@dosubot dosubot bot added platform Anything related to our platform plan ✨ feature New feature or request labels Apr 16, 2024
Copy link
Contributor

github-actions bot commented Apr 16, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@graphite-app graphite-app bot requested a review from a team April 16, 2024 10:30
Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
platform-starter-kit ❌ Failed (Inspect) May 7, 2024 0:34am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:34am
cal ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:34am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 0:34am

Copy link

graphite-app bot commented Apr 16, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seventy Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 277.61 KB 506.11 KB 144.60% (🟢 -0.28%)
/apps/[slug] 295.11 KB 523.61 KB 149.60% (🟢 -0.28%)
/apps/[slug]/[...pages] 585.77 KB 814.28 KB 232.65% (🟢 -0.31%)
/apps/categories 255.36 KB 483.86 KB 138.25% (🟢 -0.28%)
/apps/categories/[category] 259.68 KB 488.19 KB 139.48% (🟢 -0.28%)
/apps/installed/[category] 278.86 KB 507.36 KB 144.96% (🟢 -0.29%)
/availability 463.49 KB 691.99 KB 197.71% (🟢 -0.32%)
/availability/[schedule] 409.85 KB 638.35 KB 182.39% (🟢 -0.34%)
/bookings/[status] 323.11 KB 551.61 KB 157.60% (🟢 -0.29%)
/enterprise 255.42 KB 483.92 KB 138.26% (🟢 -0.27%)
/event-types 555.04 KB 783.54 KB 223.87% (🟢 -0.30%)
/event-types/[type] 434.44 KB 662.95 KB 189.41% (🟢 -0.30%)
/insights 474.32 KB 702.83 KB 200.81% (🟢 -0.28%)
/more 254.93 KB 483.43 KB 138.12% (🟢 -0.28%)
/payment/[uid] 119.16 KB 347.66 KB 99.33% (🟢 -0.15%)
/settings/admin 261.01 KB 489.51 KB 139.86% (🟢 -0.28%)
/settings/admin/apps 274.09 KB 502.6 KB 143.60% (🟢 -0.29%)
/settings/admin/apps/[category] 274.07 KB 502.58 KB 143.59% (🟢 -0.29%)
/settings/admin/flags 265.12 KB 493.62 KB 141.03% (🟢 -0.27%)
/settings/admin/impersonation 261.49 KB 489.99 KB 140.00% (🟢 -0.25%)
/settings/admin/lockedSMS 282.12 KB 510.62 KB 145.89% (🟢 -0.28%)
/settings/admin/oAuth 273.17 KB 501.67 KB 143.33% (🟢 -0.27%)
/settings/admin/orgMigrations/_OrgMigrationLayout 249.38 KB 477.88 KB 136.54% (🟢 -0.32%)
/settings/admin/orgMigrations/moveTeamToOrg 299.02 KB 527.52 KB 150.72% (🟢 -0.29%)
/settings/admin/orgMigrations/moveUserToOrg 318.38 KB 546.88 KB 156.25% (🟢 -0.30%)
/settings/admin/orgMigrations/removeTeamFromOrg 298.76 KB 527.26 KB 150.65% (🟢 -0.30%)
/settings/admin/orgMigrations/removeUserFromOrg 298.77 KB 527.28 KB 150.65% (🟢 -0.29%)
/settings/admin/organizations 262.57 KB 491.08 KB 140.31% (🟢 -0.28%)
/settings/admin/organizations/[id]/edit 261.39 KB 489.89 KB 139.97% (🟢 -0.28%)
/settings/admin/users 263.25 KB 491.75 KB 140.50% (🟢 -0.28%)
/settings/admin/users/[id]/edit 391.88 KB 620.38 KB 177.25% (🟢 -0.29%)
/settings/admin/users/add 391.61 KB 620.11 KB 177.17% (🟢 -0.29%)
/settings/billing 261.11 KB 489.62 KB 139.89% (🟢 -0.28%)
/settings/developer/api-keys 265.17 KB 493.67 KB 141.05% (🟢 -0.28%)
/settings/developer/webhooks 265.24 KB 493.75 KB 141.07% (🟢 -0.28%)
/settings/developer/webhooks/[id] 266.26 KB 494.76 KB 141.36% (🟢 -0.28%)
/settings/developer/webhooks/new 266.25 KB 494.75 KB 141.36% (🟢 -0.28%)
/settings/my-account/appearance 313.91 KB 542.41 KB 154.97% (🟢 -0.29%)
/settings/my-account/calendars 271.66 KB 500.16 KB 142.90% (🟢 -0.28%)
/settings/my-account/conferencing 272.92 KB 501.42 KB 143.26% (🟢 -0.29%)
/settings/my-account/general 376.89 KB 605.39 KB 172.97% (🟢 -0.28%)
/settings/my-account/out-of-office 265.79 KB 494.29 KB 141.23% (🟢 -0.28%)
/settings/my-account/profile 404.41 KB 632.91 KB 180.83% (🟢 -0.28%)
/settings/organizations/appearance 285.07 KB 513.57 KB 146.73% (🟢 -0.27%)
/settings/organizations/billing 261.19 KB 489.69 KB 139.91% (🟢 -0.28%)
/settings/organizations/dsync 330.41 KB 558.92 KB 159.69% (🟢 -0.27%)
/settings/organizations/general 348.7 KB 577.2 KB 164.92% (🟢 -0.33%)
/settings/organizations/members 429.51 KB 658.01 KB 188.00% (🟢 -0.27%)
/settings/organizations/platform/oauth-clients 263.69 KB 492.19 KB 140.63% (🟢 -0.28%)
/settings/organizations/platform/oauth-clients/create 263.86 KB 492.37 KB 140.68% (🟢 -0.28%)
/settings/organizations/privacy 266.78 KB 495.28 KB 141.51% (🟢 -0.28%)
/settings/organizations/profile 397.18 KB 625.68 KB 178.77% (🟢 -0.28%)
/settings/organizations/sso 271.86 KB 500.36 KB 142.96% (🟢 -0.28%)
/settings/organizations/teams/other 261.76 KB 490.26 KB 140.08% (🟢 -0.28%)
/settings/organizations/teams/other/[id]/appearance 273.9 KB 502.41 KB 143.54% (🟢 -0.27%)
/settings/organizations/teams/other/[id]/members 268.85 KB 497.36 KB 142.10% (🟢 -0.28%)
/settings/organizations/teams/other/[id]/profile 467.59 KB 696.09 KB 198.88% (🟢 -0.27%)
/settings/security/impersonation 266.02 KB 494.52 KB 141.29% (🟢 -0.28%)
/settings/security/password 303.52 KB 532.02 KB 152.01% (🟢 -0.30%)
/settings/security/sso 271.18 KB 499.68 KB 142.77% (🟢 -0.28%)
/settings/security/two-factor-auth 269.44 KB 497.94 KB 142.27% (🟢 -0.28%)
/settings/teams 260.68 KB 489.18 KB 139.77% (🟢 -0.28%)
/settings/teams/[id]/appearance 273.89 KB 502.39 KB 143.54% (🟢 -0.28%)
/settings/teams/[id]/billing 261.19 KB 489.69 KB 139.91% (🟢 -0.28%)
/settings/teams/[id]/members 378.77 KB 607.27 KB 173.51% (🟢 -0.32%)
/settings/teams/[id]/profile 468.42 KB 696.92 KB 199.12% (🟢 -0.28%)
/teams 255.15 KB 483.65 KB 138.19% (🟢 -0.28%)
/upgrade 255.27 KB 483.78 KB 138.22% (🟢 -0.28%)
/workflows 286.57 KB 515.08 KB 147.16% (🟢 -0.28%)
/workflows/[workflow] 408.93 KB 637.43 KB 182.12% (🟢 -0.30%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

deploysentinel bot commented Apr 16, 2024

Current Playwright Test Results Summary

✅ 315 Passing - ⚠️ 13 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/07/2024 12:50:34pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 93fc233

Started: 05/07/2024 12:47:37pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 2Retry 1Initial Attempt
4.98% (16) 16 / 321 runs
failed over last 7 days
30.22% (97) 97 / 321 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1Initial Attempt
0.62% (2) 2 / 325 runs
failed over last 7 days
10.77% (35) 35 / 325 runs
flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests can add single organizer address location without display location public option
Retry 1Initial Attempt
0% (0) 0 / 300 runs
failed over last 7 days
3.33% (10) 10 / 300 runs
flaked over last 7 days

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types Can create managed event type
Retry 1Initial Attempt
6.89% (21) 21 / 305 runs
failed over last 7 days
7.87% (24) 24 / 305 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1Initial Attempt
0.32% (1) 1 / 309 run
failed over last 7 days
35.60% (110) 110 / 309 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 170 runs
failed over last 7 days
50% (85) 85 / 170 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 2Retry 1Initial Attempt
19.81% (63) 63 / 318 runs
failed over last 7 days
32.39% (103) 103 / 318 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
BOOKING_RESCHEDULED when rescheduling to a booking that already exists, should send a booking rescheduled event with the existant booking uid
Retry 2Retry 1Initial Attempt
6.85% (20) 20 / 292 runs
failed over last 7 days
32.88% (96) 96 / 292 runs
flaked over last 7 days

📄   apps/web/playwright/hash-my-url.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
hash my url generate url hash
Retry 1Initial Attempt
5.61% (16) 16 / 285 runs
failed over last 7 days
29.47% (84) 84 / 285 runs
flaked over last 7 days

📄   apps/web/playwright/organization/booking.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Bookings Team Event Can create a booking for Round Robin EventType
Retry 1Initial Attempt
14.06% (45) 45 / 320 runs
failed over last 7 days
25% (80) 80 / 320 runs
flaked over last 7 days

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule for booking with seats If rescheduled/cancelled booking with seats it should display the correct number of seats
Retry 1Initial Attempt
0.35% (1) 1 / 287 run
failed over last 7 days
4.88% (14) 14 / 287 runs
flaked over last 7 days

📄   apps/web/playwright/signup.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Signup Flow Test Email verification sent if enabled
Retry 1Initial Attempt
0.91% (3) 3 / 330 runs
failed over last 7 days
6.36% (21) 21 / 330 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 1Initial Attempt
8.20% (25) 25 / 305 runs
failed over last 7 days
28.52% (87) 87 / 305 runs
flaked over last 7 days

View Detailed Build Results


Udit-takkar
Udit-takkar previously approved these changes Apr 18, 2024
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken e2e test is for impersonation. Looks like something we need to fix and not a flake.

@keithwillcode keithwillcode removed the platform Anything related to our platform plan label May 7, 2024
@Udit-takkar Udit-takkar merged commit bc0c40d into main May 7, 2024
41 checks passed
@Udit-takkar Udit-takkar deleted the feat/cal-3452-parameter-for-impersonation branch May 7, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth consumer core area: core, team members only ✨ feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3452] parameter for impersonation
5 participants