New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Overlay Calendar v2 and Troubleshooter v2 #14575
Conversation
…okens for overlay users
Merge branch 'main' into feat/overlay-calendar-v2
Merge branch 'main' into feat/overlay-calendar-v2
@kart1ka is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi - awesome work on this.
However, we do not wish to have a new OOauth provider and wish to use our current google sign in implementation. We should continue to stick with our user
model and not this new OverlayUser
model. If you signup with google for the first time here we should create a normal cal.com user.
This was on my task list for this week so let me know if you want me to take this over. Thank you very much for your contribution.
On top of this we need to ensure we are re-using all the code we already have for users and credentials instead of implementing it from scratch for this single feature. |
Hi @sean-brydon. Thanks for the review. I have a couple of questions:
|
Please reachout if you have any questions on here on in discord. Happy to help! |
Thanks. I will get on it. I will let you know if I have any other questions. |
Raised a new PR with requested changes as per the review. |
Will close this in favour of the second PR you have created <3 |
What does this PR do?
Fixes #12763
Fixes #12752
Overlay Calendar v2
https://www.loom.com/share/8e3889f4f7034596adb2bfdc640cba11?sid=7242ef08-ef5e-4b9a-a102-c19eded1d882
Troubleshooter v2
https://www.loom.com/share/8024891797574a748b99c3c40979398c?sid=248174de-8abe-4fd3-a42e-c9146b86ddf1
Type of change
<Cal.com URL>/api/auth/callback/google-for-overlay
replacing Cal.com URL with the URI at which your application runs.
How should this be tested?
<Cal.com URL>/api/auth/callback/google-for-overlay
replacing Cal.com URL with the URI at which your application runs.
Testing Overlay Calendar v2
Testing Troubleshooter v2
Mandatory Tasks