Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookings: added allow notification button #14553

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akash-singh8
Copy link

@akash-singh8 akash-singh8 commented Apr 12, 2024

What does this PR do?

Fixes # (issue)

  • Added a button for 'Allow Notifications' on the Bookings page.
  • Send notifications for events.

image

Type of change

  • New feature (non-breaking change which adds functionality)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Apr 12, 2024

@akash-singh8 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team April 12, 2024 17:56
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 12, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking ✨ feature New feature or request labels Apr 12, 2024
Copy link
Contributor

github-actions bot commented Apr 12, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "bookings" found in pull request title "bookings: added allow notification button". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

graphite-app bot commented Apr 12, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/12/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (04/12/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode added this to the v4.1 milestone Apr 15, 2024
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second step is pending.

send notifications for:

incoming events that require confirmation
any time a calendar event happens, have the location link as the destination of that notification

changing PR to draft

@Udit-takkar Udit-takkar marked this pull request as draft April 16, 2024 09:36
@PeerRich PeerRich added 🚧 wip / in the making This is currently being worked on Low priority Created by Linear-GitHub Sync labels Apr 16, 2024
Copy link
Contributor

github-actions bot commented May 1, 2024

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label May 1, 2024
@keithwillcode keithwillcode modified the milestones: v4.1, v4.2 May 15, 2024
@github-actions github-actions bot removed the Stale label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync ✨ feature New feature or request Low priority Created by Linear-GitHub Sync 🚧 wip / in the making This is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants