Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Availability Troubleshooter Only Pulls Default Availability (#13399) #14194

Closed
wants to merge 6 commits into from
Closed

fix: Availability Troubleshooter Only Pulls Default Availability (#13399) #14194

wants to merge 6 commits into from

Conversation

CrocodileZS
Copy link

What does this PR do?

When launch troubleshooter from a specific availability schedule, it will pull the availability from the specific schedule rather than the default.

Fixes #13399 #13399
https://www.loom.com/share/2bc82aee485a489c9805cf6ae0f0a4de?sid=36df0894-ae67-4551-8fd1-a88110239820

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

You could see my test video in loom video above.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Mar 23, 2024
@graphite-app graphite-app bot requested a review from a team March 23, 2024 23:08
@vercel Vercel
Copy link

vercel bot commented Mar 23, 2024

@CrocodileZS is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 23, 2024 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking Low priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Mar 23, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 23, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/23/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/23/24)

1 label was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 23, 2024 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@CarinaWolli CarinaWolli added this to the v4.0 milestone Mar 25, 2024
Udit-takkar
Udit-takkar reviewed Apr 1, 2024
View reviewed changes
packages/features/troubleshooter/components/EventScheduleItem.tsx Outdated
Comment on lines 11 to 12
const scheduleIdStr = new URLSearchParams(window.location.search).get("scheduleId");
const scheduleId = scheduleIdStr ? Number(scheduleIdStr) : null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use useRouter here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the super late reply. I'm a beginner for web development and will keep working on this issue.
I have tried useRouterQuery here to get the scheduleId.

@keithwillcode keithwillcode requested a review from a team April 13, 2024 00:13
@dosubot dosubot bot modified the milestones: v4.0, v4.1 Apr 15, 2024
@keithwillcode keithwillcode modified the milestones: v4.0, v4.1 Apr 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 4, 2024

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label May 4, 2024
@github-actions github-actions bot removed the Stale label May 7, 2024
sean-brydon
sean-brydon requested changes May 7, 2024
View reviewed changes
Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-05-07 at 09 48 10
Hi Loom looks great thanks for working on this, however, when i have tried testing this out myself with this new feature i can't get anything to load within the troubleshooter but i can when i checkout the latest main branch.

@keithwillcode
Copy link
Contributor

Closing in favor of #14693

@dosubot dosubot bot removed this from the v4.1 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar left review comments

@sean-brydon sean-brydon sean-brydon requested changes

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-3017] Availability Troubleshooter Only Pulls Default Availability
6 participants
@CrocodileZS @CLAassistant @keithwillcode @Udit-takkar @sean-brydon @CarinaWolli