feat: WIP: POC: TRPC lazy routers #14075
Conversation
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
api
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
| @@ -37,7 +36,6 @@ export type CreateInnerContextOptions = { | |||
| selectedCalendars?: Partial<SelectedCalendar>[]; | |||
| rawAvatar?: string; | |||
| }; | |||
| i18n?: Awaited<ReturnType<typeof serverSideTranslations>>; | |||
There was a problem hiding this comment.
I didn't found anywhere we're using this. And I think this is too heavy for TS inferring.
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Current Playwright Test Results Summary✅ 82 Passing - ❌ 13 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/14/2024 03:47:10pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 2da898d Started: 03/14/2024 03:43:27pm UTC ❌ Failures📄 apps/web/playwright/booking-limits.e2e.ts • 3 FailuresTop 1 Common Error Messages
Test Case Results
📄 apps/web/playwright/organization/booking.e2e.ts • 2 FailuresTop 1 Common Error Messages
Test Case Results
📄 apps/web/playwright/integrations-stripe.e2e.ts • 2 FailuresTop 1 Common Error Messages
Test Case Results
📄 apps/web/playwright/dynamic-booking-pages.e2e.ts • 2 FailuresTop 1 Common Error Messages
Test Case Results
📄 apps/web/playwright/teams.e2e.ts • 1 FailureTest Case Results
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 FailureTest Case Results
📄 packages/embeds/embed-core/playwright/tests/embed-pages.e2e.ts • 1 FailureTest Case Results
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 FailureTest Case Results
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0% (0)0 / 252 runsfailed over last 7 days |
7.54% (19)19 / 252 runsflaked over last 7 days |
📄 apps/web/playwright/signup.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Signup Flow Test Signup with valid (non premium) username
Retry 2 • Retry 1 • Initial Attempt |
1.87% (5)5 / 268 runsfailed over last 7 days |
10.07% (27)27 / 268 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
| type AppRouterType = typeof appRouter; | ||
| /** @see https://github.com/trpc/trpc/issues/2568#issuecomment-1264683718 */ | ||
| // eslint-disable-next-line @typescript-eslint/no-empty-interface | ||
| export interface AppRouter extends AppRouterType {} |
There was a problem hiding this comment.
We're starting to see these kind of errors in every import { router } from "@calcom/trpc/server/trpc"; invocation:
| import { ssoRouter } from "./sso/_router"; | ||
| import { viewerTeamsRouter } from "./teams/_router"; | ||
| import { webhookRouter } from "./webhook/_router"; | ||
| import { workflowsRouter } from "./workflows/_router"; | ||
|
|
||
| export const viewerRouter = mergeRouters( |
There was a problem hiding this comment.
Same here:
The inferred type of this node exceeds the maximum length the compiler will serialize. An explicit type annotation is needed.ts(7056)
github-actions
bot
added
Low priority
|
This PR is being marked as stale due to inactivity. |
|
This PR is being marked as stale due to inactivity. |
What does this PR do?
Putting this POC into test here:
trpc/trpc#5489
Fixes #13760
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist