Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAL-3462] Google Meet link missing after rescheduling team meeting #14086

Closed
mr-visor opened this issue Mar 14, 2024 · 3 comments · Fixed by #14730
Closed

[CAL-3462] Google Meet link missing after rescheduling team meeting #14086

mr-visor opened this issue Mar 14, 2024 · 3 comments · Fixed by #14730
Assignees
@Udit-takkar
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email High priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore.
Milestone
v4.1

Comments

@mr-visor
Copy link

mr-visor commented Mar 14, 2024 •
edited by ciaranha

Issue Summary

If someone schedules a team meeting and organizers have Google Meet connected as a default conferencing app, Google Meet link is on the event (both on the meeting scheduling page an in the email). If organizer confirms it and then reschedules the event, Google Meet link is missing from the rescheduled event (only in the email - on the meeting page it's still there).

Prerequisites

  • "Requires confirmation" option should be enabled for the event type.

Steps to Reproduce

  1. Schedule new team meeting (Google Meet should be connected) as a guest user (for example using incognito mode in the browser).
  2. Organizer should confirm it first.
  3. Then organizer should reschedule it.
  4. Check the email.

Actual Results

  • After rescheduling, the email does not have a link to Google Meet.

Expected Results

  • After rescheduling, the email have a link to Google Meet.

Technical details

Evidence

  • First email (Google Meet link is in place):

image

image

  • Rescheduling email (Google Meet link is absent):

image

image

From SyncLinear.com | CAL-3462
@maige-app maige-app bot added 🐛 bug Something isn't working teams area: teams, round robin, collective, managed event-types 📉 regressing This used to work. Now it doesn't anymore. emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email labels Mar 14, 2024
@mr-visor
Copy link
Author

Seems to be similar to #13931

@manideep1428
Copy link

It working for me. I tried many times, it works, try again

@mr-visor
Copy link
Author

mr-visor commented Mar 15, 2024 •
edited

It working for me. I tried many times, it works, try again

I have updated the steps to reproduce:

  • "Requires confirmation" option should be enabled for the event type
  • Organizer should confirm the meeting first and only then - make a reschedule

cal.com/packages/core/EventManager.ts

Line 382 in 71b0dd2

// As the reschedule requires confirmation, we can't update the events and meetings to new time yet. So, just delete them and let it be handled when organizer confirms the booking.

It looks like there's a missing use case for it (after the reschedule, event does not require confirmation from the organizer because it was already confirmed before the reschedule - so the link to Google Meet was not recreated).

@CarinaWolli CarinaWolli mentioned this issue Mar 18, 2024
Open
@ciaranha ciaranha added High priority Created by Linear-GitHub Sync bookings area: bookings, availability, timezones, double booking and removed teams area: teams, round robin, collective, managed event-types labels Apr 16, 2024
@ciaranha ciaranha added this to the v4.1 milestone Apr 16, 2024
@ciaranha ciaranha changed the title Google Meet link missing after rescheduling team meeting [CAL-3462] Google Meet link missing after rescheduling team meeting Apr 16, 2024
@Udit-takkar Udit-takkar mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Udit-takkar Udit-takkar

Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email High priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore.
Projects
None yet
Milestone
v4.1
Development

Successfully merging a pull request may close this issue.

fix: reschedule with google meet calcom/cal.com
4 participants
@mr-visor @ciaranha @Udit-takkar @manideep1428