Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAL-3029] App store install flow #13414

Open
6 tasks done
sean-brydon opened this issue Jan 26, 2024 · 3 comments · May be fixed by #14616
Open
6 tasks done

[CAL-3029] App store install flow #13414

sean-brydon opened this issue Jan 26, 2024 · 3 comments · May be fixed by #14616
Assignees
@joeauyeung
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar ✨ feature New feature or request High priority Created by Linear-GitHub Sync 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand 🚧 wip / in the making This is currently being worked on
Milestone
v4.1

Comments

@sean-brydon
Copy link
Member

sean-brydon commented Jan 26, 2024 •
edited

Take over from @morgans existing work and complete the following tasks

refactor EventTypeAppInterfaces of the apps used in event-types settings

  • split Form part from the APPcard part
  • already done for qr_code app (commit here)
  • check if there are new oAuth apps added, if yes add isOAuth to app_metadata.ts
  • adapt oauth apps api callback / add to redirect to new app install flow
  • When clicking on install new app button, only redirect to the new app install flow if it is an oAuth app or an app that extends the EventType feature in it's config
  • pr was done commit by commit for easier readability, also self review comments on the github pr

From SyncLinear.com | CAL-3029
@sean-brydon sean-brydon self-assigned this Jan 26, 2024
@sean-brydon sean-brydon added the High priority Created by Linear-GitHub Sync label Jan 26, 2024
@maige-app maige-app bot added ✨ feature New feature or request app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand 🚧 wip / in the making labels Jan 26, 2024
@sean-brydon sean-brydon added this to the v3.9 milestone Feb 15, 2024
@sean-brydon sean-brydon modified the milestones: v3.9, v4.0 Mar 16, 2024
@sean-brydon sean-brydon reopened this Apr 11, 2024
@keithwillcode
Copy link
Contributor

Putting this back into review so we do another pass of tests on it before releasing. @joeauyeung @somay_chauhan
@ebruinsma is currently pulling this commit out of main to unblock today's release

@keithwillcode keithwillcode modified the milestones: v4.0, v4.1 Apr 15, 2024
@PeerRich PeerRich added 🚧 wip / in the making This is currently being worked on and removed 🚧 wip / in the making labels Apr 16, 2024
@CarinaWolli
Copy link
Member

@somay_chauhan can this be closed or do we still need tests here?

@joeauyeung
Copy link
Contributor

@CarinaWolli still looking for a second review here as it's labelled as high risk: #14616

@joeauyeung joeauyeung linked a pull request Apr 22, 2024 that will close this issue
Open
1 task
@keithwillcode keithwillcode modified the milestones: v4.1, v4.2 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeauyeung joeauyeung

Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar ✨ feature New feature or request High priority Created by Linear-GitHub Sync 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand 🚧 wip / in the making This is currently being worked on
Projects
None yet
Milestone
v4.1
Development

Successfully merging a pull request may close this issue.

feat: events apps new install flow SomayChauhan/cal.com
5 participants
@keithwillcode @PeerRich @CarinaWolli @sean-brydon @joeauyeung