generated from cal-itp/mkdocs-template
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference for new run_events.txt spec #66
Draft
skyqrose
wants to merge
15
commits into
cal-itp:main
Choose a base branch
from
skyqrose:run_events
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rebrands "ODS" to "TODS" * Restructures data to use `_supplement` structure * Updates canonical URLs to the GitHub repo
for more information, see https://pre-commit.ci
- Corrects routes_supplement.txt instead of routes.txt - Standardizes Primary Key capitalization - Clarifies stop_times_supplement.txt grammar
`_supplement` files rebranded as Supplement files
- Clarifies Experimental field description - Adds overview information on Supplement file structure - Updates evaluation criteria - Adds example per @skyqrose - Adds Implications & Guidance
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write up of #60 in a format that can be merged. I've gone with the
event_sequence
idea instead ofrun_event_id
. Other than that there are minor text changes and some reformatting, but no semantic changes.This is currently stacked on top of #61 . The important changes are in
index.md
below## TODS-Specific File Definitions
, or you can look directly at the rendered versionI've also rewritten all of the examples (which is why there are so many deleted files). Here's a rendered version of
examples.md
Status as of 2024-04-11: I've finished the examples, and the run_events portion of this is complete (though more comments are of course welcome). This PR is now just waiting on discussion on #61 to resolve. I think we were going to vote on that one before voting on this one, but assuming both proposals are accepted, we may want to do just a single merge from this PR, since this includes everything from that PR and also fixes things up to be more consistent.