Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider Map Data Auto Update #546

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 7, 2024

It's that time again! The warehouse has delivered new data for us to use. This is an automatic pull request created by the provider-map-jobs.yml workflow; it is triggered via a cron that runs every Sunday at midnight UTC.

@github-actions github-actions bot requested a review from a team as a code owner April 7, 2024 00:23
Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for cal-itp-mobility-marketplace ready!

Name Link
🔨 Latest commit c78c2d1
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-mobility-marketplace/deploys/6611e782cd52e3000854d47a
😎 Deploy Preview https://deploy-preview-546--cal-itp-mobility-marketplace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for cal-itp-mobility-marketplace ready!

Name Link
🔨 Latest commit ee7f5e9
🔍 Latest deploy log https://app.netlify.com/sites/cal-itp-mobility-marketplace/deploys/665281295051cc0008075745
😎 Deploy Preview https://deploy-preview-546--cal-itp-mobility-marketplace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm @allejo, it looks like this auto-PR opened even though there were no changes to the data/file. Would you mind looking at this and adjusting the workflow to skip the PR when no changes are made?

@allejo
Copy link
Contributor

allejo commented Apr 8, 2024

Yeah, let me investigate; it looks like this was triggered because the GeoJSON generation gets saved without a newline. So that's "different," and then our formatter is running as a separate commit after the PR is opened and adding that newline. In the end, they cancel each other out, and you end up with this PR.

My thinking is to run the formatting as part of the GeoJSON commit process to avoid this.

@github-actions github-actions bot force-pushed the create-pull-request/patch branch 2 times, most recently from c2dabbc to c2e5f9a Compare April 21, 2024 00:22
@github-actions github-actions bot force-pushed the create-pull-request/patch branch 2 times, most recently from 5a01ea2 to b281116 Compare May 4, 2024 23:28
@allejo allejo dismissed thekaveman’s stale review May 4, 2024 23:30

feedback addressed

@allejo allejo requested a review from thekaveman May 4, 2024 23:31
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from b281116 to e1e6def Compare May 5, 2024 00:23
@github-actions github-actions bot force-pushed the create-pull-request/patch branch 2 times, most recently from 9b8cf93 to b577071 Compare May 19, 2024 00:23
@allejo
Copy link
Contributor

allejo commented May 26, 2024

@thekaveman this is on you to approve and merge 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants