-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: system enrollment error - 500 error during /token #2089
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
fa77a8e
to
95ec106
Compare
4b7bb60
to
17de9a1
Compare
Rebased on |
0077b6a
to
384910a
Compare
384910a
to
3769a00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I made the suggested modification in the view and was sent to the expected error page when trying to acquire the access token.
if (data.redirect) { | ||
// https://stackoverflow.com/a/42469170 | ||
// use 'assign' because 'replace' was giving strange Back button behavior | ||
window.location.assign(data.redirect); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not worried about this as blocking this PR, but...
I wonder if window.location.replace
is the right method here instead? Do we want to support the back button when the user is supposed to wait and not try again immediately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created #2119 to follow up on this
Part of #2032
/token
returns a JSON response that is used to send user to/enrollment/error
/enrollment/error
shows system enrollment error templatefailed access token request
withstatus_code
inevent_properties
)Reviewing / testing
Similar to review steps for #2088, you can add some code locally to simulate a 500 error.
To
/token
, add: