Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: eligibility start update copy #2042

Merged
merged 1 commit into from Apr 25, 2024
Merged

Feat: eligibility start update copy #2042

merged 1 commit into from Apr 25, 2024

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented Apr 19, 2024 •
edited

Closes #2010

This PR updates the eligibility/start copy as shown in Figma.

Desktop

Before (using test-benefits) After (this branch) Figma
image image image

Mobile

Before (using test-benefits) After (this branch) Figma
image image image

@lalver1 lalver1 self-assigned this Apr 19, 2024
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Apr 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited

Coverage report

This PR does not seem to contain any modification to coverable code.

@lalver1 lalver1 marked this pull request as ready for review April 22, 2024 13:59
@lalver1 lalver1 requested a review from a team as a code owner April 22, 2024 13:59
@lalver1 lalver1 marked this pull request as draft April 22, 2024 14:54
@lalver1 lalver1 force-pushed the feat/eligibility-start-copy branch 2 times, most recently from f0e0818 to 41e15f6 Compare April 22, 2024 19:57
@lalver1 lalver1 marked this pull request as ready for review April 22, 2024 20:05
@lalver1 lalver1 force-pushed the feat/eligibility-start-copy branch from 41e15f6 to 4e09f0a Compare April 25, 2024 17:46
angela-tran
angela-tran approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@angela-tran angela-tran mentioned this pull request Apr 25, 2024
Merged
@lalver1 lalver1 merged commit c48e898 into dev Apr 25, 2024
9 checks passed
@lalver1 lalver1 deleted the feat/eligibility-start-copy branch April 25, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@lalver1 lalver1

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Milestone
Improved UX for agency card enrollment
Development

Successfully merging this pull request may close these issues.

Eligibility start: update copy to be more consistent
3 participants
@lalver1 @angela-tran @thekaveman