Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: enrollment expiry session #1987

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Fix: enrollment expiry session #1987

merged 2 commits into from
Mar 26, 2024

Conversation

thekaveman
Copy link
Member

Quick follow-up to #1985

  • Forgot to activate the new context processor in settings.py
  • Forgot to clear the enrollment expiry in session.reset()

@thekaveman thekaveman added the bug Something isn't working label Mar 26, 2024
@thekaveman thekaveman self-assigned this Mar 26, 2024
@thekaveman thekaveman requested a review from a team as a code owner March 26, 2024 21:55
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.) back-end Django views, sessions, middleware, models, migrations etc. labels Mar 26, 2024
@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/core
  session.py
Project Total  

This report was generated by python-coverage-comment-action

angela-tran
angela-tran approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks!

@thekaveman thekaveman merged commit e728782 into dev Mar 26, 2024
17 checks passed
@thekaveman thekaveman deleted the fix/enrollment-expiry-session branch March 26, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. bug Something isn't working deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.)
Projects
Digital Services
Status: Done
Milestone
Low-income rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thekaveman @angela-tran