Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: Revert platform change #1743

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Docker: Revert platform change #1743

merged 1 commit into from
Sep 25, 2023

Conversation

machikoyasuda
Copy link
Member

closes #1730

When I run docker compose run --entrypoint bash client on my machine now, with this PR, I'm able to get to bash properly.

@machikoyasuda machikoyasuda requested a review from a team as a code owner September 20, 2023 23:05
@github-actions github-actions bot added the docker Application container, devcontainer, Compose, etc. label Sep 20, 2023
@machikoyasuda machikoyasuda self-assigned this Sep 20, 2023
@thekaveman
Copy link
Member

And just to confirm @machikoyasuda all the other Docker stuff works still, right?

Like docker compose up -d client and running the devcontainer and docs site locally?

@machikoyasuda
Copy link
Member Author

@thekaveman I did a full reinstall of everything just to be sure - and it all works: devcontainer, app with full login.gov flow, tests, docs

thekaveman
thekaveman approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the app and devcontainer locally 👍

@machikoyasuda machikoyasuda merged commit 85a130d into dev Sep 25, 2023
10 checks passed
@machikoyasuda machikoyasuda deleted the chore/1730-docker-revert branch September 25, 2023 19:15
@thekaveman thekaveman mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

@angela-tran angela-tran angela-tran approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
docker Application container, devcontainer, Compose, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert Fix: Docker platform issue
3 participants
@machikoyasuda @thekaveman @angela-tran