Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.NotSupportedException: Cake does not support /v2/gotodefinition #137

Closed
nils-a opened this issue Aug 11, 2021 · 3 comments
Closed

Comments

@nils-a
Copy link
Member

nils-a commented Aug 11, 2021

I noticed GoToDefinition is no longer working.
the log shows:

[dbug]: OmniSharp.Stdio.Host
        ************ Request ************
{
  "Type": "request",
  "Seq": 42,
  "Command": "/v2/gotodefinition",
  "Arguments": {
    "FileName": "d:\\_dev\\test\\Nils.Cake",
    "Line": 7,
    "Column": 23,
    "WantMetadata": true
  }
}
[fail]: OmniSharp.Stdio.Host
        ************  Response (0.5418ms) ************ 
{
  "Request_seq": 42,
  "Command": "/v2/gotodefinition",
  "Running": true,
  "Success": false,
  "Message": "\"System.NotSupportedException: Cake does not support /v2/gotodefinition\\r\\n   at OmniSharp.Endpoint.EndpointHandler`2.<HandleRequestForLanguage>d__20.MoveNext() in D:\\\\a\\\\1\\\\s\\\\src\\\\OmniSharp.Host\\\\Endpoint\\\\EndpointHandler.cs:line 233\\r\\n--- End of stack trace from previous location where exception was thrown ---\\r\\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\\r\\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\\r\\n   at OmniSharp.Endpoint.EndpointHandler`2.<Process>d__16.MoveNext() in D:\\\\a\\\\1\\\\s\\\\src\\\\OmniSharp.Host\\\\Endpoint\\\\EndpointHandler.cs:line 131\\r\\n--- End of stack trace from previous location where exception was thrown ---\\r\\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\\r\\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\\r\\n   at OmniSharp.Stdio.Host.<HandleRequest>d__14.MoveNext() in D:\\\\a\\\\1\\\\s\\\\src\\\\OmniSharp.Stdio\\\\Host.cs:line 218\"",
  "Body": null,
  "Seq": 666,
  "Type": "response"
}

I'm guessing this came with https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.23.13

@nils-a
Copy link
Member Author

nils-a commented Aug 16, 2021

I'm guessing this issue does not belong here, but rather in OmniSharp/omnisharp-roslyn.
Actually I'm guessing it's a regression from OmniSharp/omnisharp-roslyn#2168 : I think OmniSharp.Cake/**/GotoDefinitionHandler.cs should have been modified as well in that PR.

@nils-a
Copy link
Member Author

nils-a commented Oct 6, 2021

OmniSharp/omnisharp-roslyn#2212 has been merged. Now, the only thing missing is a new version of O#. 🎉

@nils-a
Copy link
Member Author

nils-a commented Nov 11, 2021

@nils-a nils-a closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant