Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.NotSupportedException: Cake does not support /v2/gotodefinition #2209

Closed
nils-a opened this issue Aug 16, 2021 · 0 comments · Fixed by #2212
Closed

System.NotSupportedException: Cake does not support /v2/gotodefinition #2209

nils-a opened this issue Aug 16, 2021 · 0 comments · Fixed by #2212
Labels

Comments

@nils-a
Copy link
Contributor

nils-a commented Aug 16, 2021

I raised this issue first in cake-build/bakery#137 - but I think it "belongs" here.

GoToDefinition in Cake files is no longer working (not sure since when..)

the log shows:

[dbug]: OmniSharp.Stdio.Host
        ************ Request ************
{
  "Type": "request",
  "Seq": 42,
  "Command": "/v2/gotodefinition",
  "Arguments": {
    "FileName": "d:\\_dev\\test\\Nils.Cake",
    "Line": 7,
    "Column": 23,
    "WantMetadata": true
  }
}
[fail]: OmniSharp.Stdio.Host
        ************  Response (0.5418ms) ************ 
{
  "Request_seq": 42,
  "Command": "/v2/gotodefinition",
  "Running": true,
  "Success": false,
  "Message": "\"System.NotSupportedException: Cake does not support /v2/gotodefinition\\r\\n   at OmniSharp.Endpoint.EndpointHandler`2.<HandleRequestForLanguage>d__20.MoveNext() in D:\\\\a\\\\1\\\\s\\\\src\\\\OmniSharp.Host\\\\Endpoint\\\\EndpointHandler.cs:line 233\\r\\n--- End of stack trace from previous location where exception was thrown ---\\r\\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\\r\\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\\r\\n   at OmniSharp.Endpoint.EndpointHandler`2.<Process>d__16.MoveNext() in D:\\\\a\\\\1\\\\s\\\\src\\\\OmniSharp.Host\\\\Endpoint\\\\EndpointHandler.cs:line 131\\r\\n--- End of stack trace from previous location where exception was thrown ---\\r\\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\\r\\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\\r\\n   at OmniSharp.Stdio.Host.<HandleRequest>d__14.MoveNext() in D:\\\\a\\\\1\\\\s\\\\src\\\\OmniSharp.Stdio\\\\Host.cs:line 218\"",
  "Body": null,
  "Seq": 666,
  "Type": "response"
}

I'm guessing this came with https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.23.13

Digging a bit deeper I'm guessing it's a regression from #2168 : I think OmniSharp.Cake/**/GotoDefinitionHandler.cs should have been "modified" as well.

@filipw filipw added the cake label Aug 17, 2021
nils-a added a commit to nils-a/omnisharp-roslyn that referenced this issue Aug 22, 2021
filipw added a commit to nils-a/omnisharp-roslyn that referenced this issue Sep 27, 2021
filipw added a commit to nils-a/omnisharp-roslyn that referenced this issue Oct 1, 2021
filipw added a commit that referenced this issue Oct 6, 2021
(#2209) implemented /v2/gotodefinition for Cake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants