Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Introduce typedefs for inclination, power, heart rate, cadence, peloton resistance #2270

Closed
drmason789 opened this issue Apr 2, 2024 · 4 comments
Labels
wontfix This will not be worked on
Milestone

Comments

@drmason789
Copy link
Contributor

drmason789 commented Apr 2, 2024

@cagnulein Remember the resistance_t change? Would you be agreeable to me adding cadence_t, heartRate_t, power_t, pelotonResistance_t, inclination_t alongside it and propagating throughout the codebase, in a different PR?

@drmason789 yes sure!

Originally posted by @cagnulein in #2174 (comment)

@drmason789
Copy link
Contributor Author

I've volunteered to do this.

@drmason789
Copy link
Contributor Author

typedef int8_t peloton_t;
typedef int16_t power_t;
typedef int16_t cadence_t;
typedef double inclination_t;

Using signed ints initially even though negative values don't make sense, for use with the "no value" pattern pre-#2269

drmason789 added a commit to drmason789/qdomyos-zwift that referenced this issue Apr 2, 2024
drmason789 added a commit to drmason789/qdomyos-zwift that referenced this issue Apr 2, 2024
@cagnulein cagnulein added this to the 2.16 milestone Apr 3, 2024
Copy link

stale bot commented Apr 20, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 20, 2024
@stale stale bot closed this as completed Apr 28, 2024
@cagnulein cagnulein reopened this Apr 28, 2024
@stale stale bot removed the wontfix This will not be worked on label Apr 28, 2024
Copy link

stale bot commented May 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 13, 2024
@stale stale bot closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants