feat: Use caddy's internal Proxy protocol module #166
Conversation
Also deprecated the one we have as it's redundant with the one included in caddy. Because it's the same library behind, I do not expect any breaking change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
=======================================
Coverage 37.08% 37.08%
=======================================
Files 12 12
Lines 364 364
=======================================
Hits 135 135
Misses 228 228
Partials 1 1 ☔ View full report in Codecov by Sentry. |
| @@ -3,7 +3,7 @@ module github.com/caddyserver/ingress | |||
| go 1.21 | |||
|
|
|||
| require ( | |||
| github.com/caddyserver/caddy/v2 v2.7.5 | |||
| github.com/caddyserver/caddy/v2 v2.7.6-0.20231024195719-67e567b7ecec | |||
There was a problem hiding this comment.
@Embraser01 do we need a version change here?
There was a problem hiding this comment.
Not sure on how long we will have to wait before a tagged version, no reason to update yet, I created this PR after testing it to check if everything was working great.
Maybe @mholt can give us a little bit of insight on when the next version will be released?
There was a problem hiding this comment.
I suppose we can get rid of this file completely, right?
There was a problem hiding this comment.
This may break some workflows even if I don't think a lot of people use it. I think we can remove it anyway as there will be an alternative included
Also deprecated the one we have as it's redundant with the one included in caddy and people should use the one provided by caddy.
Because it's the same library behind, I do not expect any breaking change.
I'll let it in draft until the new proxyprotol module is merged and released in caddy (caddyserver/caddy#5915)