draft: attempt to unify process-compose settings #1161
Draft
+34
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started updating
process.process-compose
to allow overriding individual settings without losing any of the defaults.But I noticed that, despite the description, those settings are never used.
What needs to be fixed
process.process-compose
attrs
{ version = "0.5"; ... }
tui
andunix-socket
.process.process-compose.tui
any
true
--tui
CLI optionprocess.process-compose.unix-socket
any
"${config.devenv.runtime}/pc.sock"
--unix-socket
path.process.process-compose.settings
yaml
{}
implementation in configprocess-managers.process-compose.settings.tui
bool
lib.mkDefault true
process-managers.process-compose.settings.port
int
lib.mkDefault 9999
Other issues
tui = false;
breaks process-compose. Fixed by serializing the bool totrue
orfalse
, instead of"1"
and""
.PC_TUI_ENABLED
doesn't exist inprocess-compose
. There'sPC_DISABLE_TUI
though. edit: nevermind, looks like this exists for backwards-compatibility with previous devenv versions. We should document this. See unable to change process-compose tui #1109.Proposal
process.process-compose
process-managers.process-compose.settings
.process.process-compose.tui
process-managers.process-compose.tui
.process.process-compose.unix-socket
process-managers.process-compose.unixSocket
. Orunix-socket
🤷.process-managers.process-compose.settings
process-managers.process-compose.settings.port
process-managers.process-compose.port
.process-managers.process-compose.settings.tui
process-managers.process-compose.useUnixSocket
true
by default and controls the--use-uds
CLI flag. Or enable whenport = 0
.