Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [xalign] fix buy side max amount #1608

Merged
merged 2 commits into from Mar 28, 2024
Merged

Conversation

narumiruna
Copy link
Collaborator

No description provided.

@narumiruna narumiruna requested a review from c9s March 27, 2024 08:36
@bbgokarma-bot
Copy link

Welcome back! @narumiruna, This pull request may get 207 BBG.

@@ -288,6 +284,8 @@ func (s *Strategy) selectSessionForCurrency(
Market: market,
TimeInForce: types.TimeInForceGTC,
}
} else {
log.Infof("The amount %f is not greater than the minimal order quantity for %s", q.Float64(), market.Symbol)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Warnf ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 225 BBG

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 22.62%. Comparing base (e010619) to head (c2c650a).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
- Coverage   22.64%   22.62%   -0.03%     
==========================================
  Files         620      621       +1     
  Lines       44884    44908      +24     
==========================================
- Hits        10166    10162       -4     
- Misses      33989    34014      +25     
- Partials      729      732       +3     
Files Coverage Δ
pkg/strategy/xalign/strategy.go 32.52% <0.00%> (-1.28%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e010619...c2c650a. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 235 BBG

@narumiruna narumiruna merged commit 3881039 into main Mar 28, 2024
3 of 5 checks passed
@narumiruna narumiruna deleted the narumi/xalign/fix-max-amount branch March 28, 2024 06:09
@bbgokarma-bot
Copy link

Hi @narumiruna,

Well done! 250 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x5be209016d55aa58bd100242e62d5f07419a26c1c07c5e7188cd789a6242898c

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants