Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default value for config param of backtest cmd to have same value with root cmd #1600

Merged
merged 1 commit into from Mar 22, 2024

Conversation

lanphan
Copy link
Contributor

@lanphan lanphan commented Mar 22, 2024

No description provided.

@bbgokarma-bot
Copy link

Hi @lanphan,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 205 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

--
If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best,
KarmaBot

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2024

CLA assistant check
All committers have signed the CLA.

@lanphan
Copy link
Contributor Author

lanphan commented Mar 22, 2024

polygon:0x7DdBBe7E5fF0cBDfc18CA22ba086e71d3f6aeb73

@bbgokarma-bot
Copy link

Hi @lanphan,

You left an invalid address format, please write your address with the following format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

@bbgokarma-bot
Copy link

Great! @lanphan, I've memorized your address.

@lanphan
Copy link
Contributor Author

lanphan commented Mar 22, 2024

polygon:0x7DdBBe7E5fF0cBDfc18CA22ba086e71d3f6aeb73

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.57%. Comparing base (abd9f86) to head (e2c7540).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1600   +/-   ##
=======================================
  Coverage   22.57%   22.57%           
=======================================
  Files         619      619           
  Lines       44832    44832           
=======================================
  Hits        10122    10122           
  Misses      33982    33982           
  Partials      728      728           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd9f86...e2c7540. Read the comment docs.

@c9s c9s merged commit c9f1764 into c9s:main Mar 22, 2024
5 checks passed
@bbgokarma-bot
Copy link

Hi @lanphan,

Well done! 240 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xc90094eefdca7be04af1d93aed048aab7b32040ab77a5ce40b59a9d8f6129624

Thank you for your contribution!

@lanphan lanphan deleted the minor1 branch March 22, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants