Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: [max] simplify max query ticker #1595

Merged
merged 1 commit into from Mar 26, 2024
Merged

Conversation

c9s
Copy link
Owner

@c9s c9s commented Mar 19, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 462 BBG.

@c9s c9s force-pushed the c9s/simplify-max-query-ticker branch from afc664f to 1326ffb Compare March 19, 2024 07:48
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 467 BBG

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 22.59%. Comparing base (693b641) to head (1326ffb).
Report is 10 commits behind head on main.

❗ Current head 1326ffb differs from pull request most recent head d399b39. Consider uploading reports for the commit d399b39 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1595      +/-   ##
==========================================
+ Coverage   22.57%   22.59%   +0.01%     
==========================================
  Files         619      619              
  Lines       44832    44833       +1     
==========================================
+ Hits        10122    10130       +8     
+ Misses      33982    33976       -6     
+ Partials      728      727       -1     
Files Coverage Δ
pkg/bbgo/session.go 8.22% <0.00%> (ø)
pkg/exchange/max/exchange.go 0.34% <0.00%> (-0.01%) ⬇️
pkg/strategy/xalign/strategy.go 33.80% <71.42%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693b641...d399b39. Read the comment docs.

@c9s c9s enabled auto-merge March 19, 2024 08:12
@c9s c9s force-pushed the c9s/simplify-max-query-ticker branch from 1326ffb to d399b39 Compare March 26, 2024 10:17
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 223 BBG

@c9s c9s merged commit d61498c into main Mar 26, 2024
3 checks passed
@c9s c9s deleted the c9s/simplify-max-query-ticker branch March 26, 2024 10:28
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 228 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x2d7d2dd23728609e58837ce6bb4029489a17a8b482d537c1e5b16a7113dafb7f

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants