Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [xalign] correct the base/quote currency balance name when it's reversed #1592

Merged
merged 1 commit into from Mar 19, 2024

Conversation

c9s
Copy link
Owner

@c9s c9s commented Mar 18, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 224 BBG.

@c9s c9s force-pushed the c9s/fix-xalign-side-for-reversed-quote branch from 85b9e6b to c11f886 Compare March 18, 2024 16:31
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 221 BBG

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.53%. Comparing base (22221a8) to head (c11f886).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1592   +/-   ##
=======================================
  Coverage   22.53%   22.53%           
=======================================
  Files         618      618           
  Lines       44528    44528           
=======================================
  Hits        10034    10034           
  Misses      33779    33779           
  Partials      715      715           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22221a8...c11f886. Read the comment docs.

@c9s c9s merged commit 3e14c14 into main Mar 19, 2024
5 checks passed
@c9s c9s deleted the c9s/fix-xalign-side-for-reversed-quote branch March 19, 2024 02:37
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 231 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xe3502b0e1cede4c7f64e6940311f7dfd9bcaf532fcad5b20ec60fc02efd4fc25

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants