Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dca2: add ttl for persistence and nextRoundPaused flag #1589

Merged
merged 1 commit into from Mar 19, 2024

Conversation

kbearXD
Copy link
Collaborator

@kbearXD kbearXD commented Mar 18, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @kbearXD, This pull request may get 235 BBG.

Base automatically changed from kbearXD/dca2/round-collector to main March 18, 2024 09:34
@kbearXD kbearXD force-pushed the kbearXD/dca2/pause-next-round-and-set-ttl branch from a11cddb to bcc29bd Compare March 18, 2024 09:35
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 240 BBG

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 22.52%. Comparing base (3f44092) to head (bcc29bd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
- Coverage   22.53%   22.52%   -0.01%     
==========================================
  Files         618      618              
  Lines       44524    44540      +16     
==========================================
  Hits        10034    10034              
- Misses      33775    33791      +16     
  Partials      715      715              
Files Coverage Δ
pkg/strategy/dca2/state.go 0.00% <0.00%> (ø)
pkg/strategy/dca2/strategy.go 0.71% <0.00%> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f44092...bcc29bd. Read the comment docs.

@kbearXD kbearXD merged commit b0bbf3c into main Mar 19, 2024
3 of 5 checks passed
@kbearXD kbearXD deleted the kbearXD/dca2/pause-next-round-and-set-ttl branch March 19, 2024 06:31
@bbgokarma-bot
Copy link

Hi @kbearXD,

Well done! 250 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xc922ca50fe815dbc09662c4c0baba451ed46e84c7b186390c5e287dd72358442

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants