Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dca2: new struct RoundCollector for testing and use flag to decide re… #1586

Merged
merged 1 commit into from Mar 18, 2024

Conversation

kbearXD
Copy link
Collaborator

@kbearXD kbearXD commented Mar 15, 2024

…covery

@bbgokarma-bot
Copy link

Welcome back! @kbearXD, This pull request may get 396 BBG.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 126 lines in your changes are missing coverage. Please review.

Project coverage is 22.51%. Comparing base (239f7ea) to head (a23c476).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1586      +/-   ##
==========================================
- Coverage   22.53%   22.51%   -0.03%     
==========================================
  Files         617      618       +1     
  Lines       44478    44520      +42     
==========================================
  Hits        10023    10023              
- Misses      33740    33782      +42     
  Partials      715      715              
Files Coverage Δ
pkg/strategy/dca2/state.go 0.00% <0.00%> (ø)
pkg/strategy/dca2/recover.go 37.07% <0.00%> (-1.08%) ⬇️
pkg/strategy/dca2/strategy.go 0.75% <0.00%> (+0.10%) ⬆️
pkg/strategy/dca2/round_collector.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 239f7ea...a23c476. Read the comment docs.

@kbearXD kbearXD merged commit 3f44092 into main Mar 18, 2024
3 of 5 checks passed
@kbearXD kbearXD deleted the kbearXD/dca2/round-collector branch March 18, 2024 09:34
@bbgokarma-bot
Copy link

Hi @kbearXD,

Well done! 406 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x228b611866f2453f4b8426560e392e3c58926a614891869349a00a78cb38dc95

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants