Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [dca2] must calculate and emit profit at the end of the round #1580

Merged
merged 3 commits into from
Mar 14, 2024

new function IsFilledOrderState for maxapi

2b52211
Select commit
Failed to load commit list.
Merged

FIX: [dca2] must calculate and emit profit at the end of the round #1580

new function IsFilledOrderState for maxapi
2b52211
Select commit
Failed to load commit list.
Codecov / codecov/project failed Mar 14, 2024 in 0s

22.39% (-0.01%) compared to 3a98660

View this Pull Request on Codecov

22.39% (-0.01%) compared to 3a98660

Details

Codecov Report

Attention: Patch coverage is 2.70270% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 22.39%. Comparing base (3a98660) to head (2b52211).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
- Coverage   22.40%   22.39%   -0.01%     
==========================================
  Files         615      616       +1     
  Lines       44436    44459      +23     
==========================================
+ Hits         9954     9955       +1     
- Misses      33772    33794      +22     
  Partials      710      710              
Files Coverage Δ
pkg/strategy/dca2/state.go 0.00% <0.00%> (ø)
pkg/exchange/max/maxapi/order.go 0.00% <0.00%> (ø)
pkg/strategy/dca2/recover.go 38.15% <10.00%> (+0.79%) ⬆️
pkg/strategy/dca2/strategy.go 0.65% <0.00%> (-0.06%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a98660...2b52211. Read the comment docs.