Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [okx] remove the query after place order #1578

Merged
merged 1 commit into from Mar 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 15 additions & 9 deletions pkg/exchange/okex/exchange.go
Expand Up @@ -260,6 +260,7 @@ func (e *Exchange) SubmitOrder(ctx context.Context, order types.SubmitOrder) (*t
orderReq.ClientOrderID(order.ClientOrderID)
}

timeNow := time.Now()
orders, err := orderReq.Do(ctx)
if err != nil {
return nil, err
Expand All @@ -269,16 +270,21 @@ func (e *Exchange) SubmitOrder(ctx context.Context, order types.SubmitOrder) (*t
return nil, fmt.Errorf("unexpected length of order response: %v", orders)
}

orderRes, err := e.QueryOrder(ctx, types.OrderQuery{
Symbol: order.Symbol,
OrderID: orders[0].OrderID,
ClientOrderID: orders[0].ClientOrderID,
})
orderID, err := strconv.ParseUint(orders[0].OrderID, 10, 64)
if err != nil {
return nil, fmt.Errorf("failed to query order by id: %s, clientOrderId: %s, err: %w", orders[0].OrderID, orders[0].ClientOrderID, err)
}

return orderRes, nil
return nil, fmt.Errorf("failed to parse response order id: %w", err)
}

return &types.Order{
SubmitOrder: order,
Exchange: types.ExchangeOKEx,
OrderID: orderID,
Status: types.OrderStatusNew,
ExecutedQuantity: fixedpoint.Zero,
IsWorking: true,
CreationTime: types.Time(timeNow),
UpdateTime: types.Time(timeNow),
}, nil

// TODO: move this to batch place orders interface
/*
Expand Down