Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [xfunding] add many fixes and improvements #1568

Merged
merged 10 commits into from Mar 6, 2024
Merged

FIX: [xfunding] add many fixes and improvements #1568

merged 10 commits into from Mar 6, 2024

Conversation

c9s
Copy link
Owner

@c9s c9s commented Mar 6, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 311 BBG.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 21.98%. Comparing base (f84aa26) to head (e244402).
Report is 4 commits behind head on main.

❗ Current head e244402 differs from pull request most recent head b77618f. Consider uploading reports for the commit b77618f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1568      +/-   ##
==========================================
- Coverage   21.98%   21.98%   -0.01%     
==========================================
  Files         615      615              
  Lines       44410    44413       +3     
==========================================
  Hits         9764     9764              
- Misses      33953    33956       +3     
  Partials      693      693              
Files Coverage Δ
pkg/strategy/common/profit_fixer.go 0.00% <0.00%> (ø)
pkg/strategy/xdepthmaker/strategy.go 14.30% <0.00%> (-0.09%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a8dc0...b77618f. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 321 BBG

@c9s c9s merged commit f7cce9f into main Mar 6, 2024
3 checks passed
@c9s c9s deleted the c9s/xfunding-fix branch March 6, 2024 14:48
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 326 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x9e1374e199df2b607b0c45689859a901383310d8169a98f3f0cbacb189097b78

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants