Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [xdepthmaker] add profit fixer #1559

Merged
merged 5 commits into from Mar 5, 2024
Merged

Conversation

c9s
Copy link
Owner

@c9s c9s commented Mar 5, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 320 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 325 BBG

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 21.79%. Comparing base (88a5579) to head (26c3461).
Report is 5 commits behind head on main.

❗ Current head 26c3461 differs from pull request most recent head 0d3483e. Consider uploading reports for the commit 0d3483e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1559      +/-   ##
==========================================
+ Coverage   21.62%   21.79%   +0.16%     
==========================================
  Files         614      615       +1     
  Lines       44316    44372      +56     
==========================================
+ Hits         9584     9670      +86     
+ Misses      34049    34014      -35     
- Partials      683      688       +5     
Files Coverage Δ
pkg/types/profit.go 0.00% <0.00%> (ø)
pkg/strategy/xdepthmaker/strategy.go 14.78% <0.00%> (-0.32%) ⬇️
pkg/strategy/xdepthmaker/profitfixer.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88a5579...0d3483e. Read the comment docs.

Copy link
Collaborator

@ycdesu ycdesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some minor comments.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 391 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 398 BBG

@c9s c9s force-pushed the c9s/xdepthmaker-pnl-fixer branch from 3c389d1 to 26c3461 Compare March 5, 2024 13:14
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 413 BBG

@c9s c9s enabled auto-merge March 5, 2024 13:14
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 440 BBG

@c9s c9s merged commit 096fac5 into main Mar 5, 2024
3 checks passed
@c9s c9s deleted the c9s/xdepthmaker-pnl-fixer branch March 5, 2024 13:24
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 455 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xe0369af363e48c5909a6f93be3e046ea044dbe5bb5eeb37a48a8cee442b0b052

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants